Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testShaftRotatesInAutonomous fails occasionally #94

Closed
brettle opened this issue Jul 7, 2024 · 3 comments
Closed

testShaftRotatesInAutonomous fails occasionally #94

brettle opened this issue Jul 7, 2024 · 3 comments

Comments

@brettle
Copy link
Member

brettle commented Jul 7, 2024

It just succeeded on my local machine 17 times in a row and then failed with:

org.opentest4j.AssertionFailedError: Shaft close to target rotation ==> expected: <160.0> but was: <95.42188982042626>
	at app//org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
	at app//org.junit.jupiter.api.AssertionUtils.failNotEqual(AssertionUtils.java:62)
	at app//org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:86)
	at app//org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:1020)
	at app//frc.robot.PWMMotorControllerTest.lambda$testShaftRotatesInAutonomous$1(PWMMotorControllerTest.java:31)
	at app//org.carlmontrobotics.libdeepbluesim.WebotsSimulator.runAllCallbacks(WebotsSimulator.java:467)
	at app//org.carlmontrobotics.libdeepbluesim.WebotsSimulator.lambda$waitForUserToStart$6(WebotsSimulator.java:377)
	at java.base@17.0.8.1/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
	at java.base@17.0.8.1/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
	at java.base@17.0.8.1/java.lang.Thread.run(Thread.java:833)

Might just need to increase the tolerance.

@brettle brettle mentioned this issue Jul 7, 2024
@brettle
Copy link
Member Author

brettle commented Jul 7, 2024

This is probably best worked on after #88.

@brettle
Copy link
Member Author

brettle commented Jul 13, 2024

Will probably be fixed by a fix to #101.

@brettle
Copy link
Member Author

brettle commented Jul 17, 2024

Should be addressed by PR #114. Reopen if another assertion failure is seen.

@brettle brettle closed this as completed Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant