Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve reproducability of simulations #101

Closed
brettle opened this issue Jul 9, 2024 · 1 comment
Closed

Improve reproducability of simulations #101

brettle opened this issue Jul 9, 2024 · 1 comment
Assignees

Comments

@brettle
Copy link
Member

brettle commented Jul 9, 2024

At the moment, WebotsSimulator and the controller synchonize time via NetworkTables but the actual sim values are sent via the halsim WebSockets server. As a result, there is a race condition between the 2 and the simulator might step forward before receiveing all of the new sim actuator values or the robot might step forward before receiving all of the sim sensor values.

One option would be moving the time sync back to halsim if we can avoid the hangs we were seeing in an earlier implementation. Those might be avoidable if we ensure that none of the processing happens directly in the callbacks but is instead queued for processing in a separate thread.

@brettle
Copy link
Member Author

brettle commented Jul 17, 2024

Fixed by PR #114.

@brettle brettle closed this as completed Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant