Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/sg 000 reduce import loops risk #636

Merged
merged 22 commits into from
Jan 22, 2023

Conversation

Louis-Dupont
Copy link
Contributor

@Louis-Dupont Louis-Dupont commented Jan 18, 2023

PR to prevent import loops that blocked me on the DeciClient PR. It's basically just using full import path, and moving one function from training to common:

@dagshub
Copy link

dagshub bot commented Jan 18, 2023

@Louis-Dupont Louis-Dupont marked this pull request as ready for review January 18, 2023 13:16
Copy link
Collaborator

@ofrimasad ofrimasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just two minor comments

Copy link
Collaborator

@ofrimasad ofrimasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Louis-Dupont Louis-Dupont merged commit 689df58 into master Jan 22, 2023
@Louis-Dupont Louis-Dupont deleted the hotfix/SG-000-reduce_import_loops_risk branch January 22, 2023 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants