Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/sg 627 add dev option for DeciClient #627

Merged
merged 31 commits into from
Jan 22, 2023

Conversation

Louis-Dupont
Copy link
Contributor

@Louis-Dupont Louis-Dupont commented Jan 16, 2023

Relies on #636
(to fix an import loop)

@dagshub
Copy link

dagshub bot commented Jan 16, 2023

@Louis-Dupont Louis-Dupont marked this pull request as ready for review January 21, 2023 20:59
Copy link
Collaborator

@ofrimasad ofrimasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great.
a few comments inline

Copy link
Collaborator

@ofrimasad ofrimasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Louis-Dupont Louis-Dupont merged commit a6bfe6b into master Jan 22, 2023
@Louis-Dupont Louis-Dupont deleted the feature/SG-627-add_dev_option branch January 22, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants