Add post_install_message in gemspec #3723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TonyCTHsu
added
the
dev/internal
marcotc
reviewed
Jun 18, 2024
marcotc
reviewed
Jun 18, 2024
ivoanjo
reviewed
Jun 19, 2024
TonyCTHsu
force-pushed
the
tonycthsu/post-install-message
branch
from
152bba1
to
0a86bc4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 1.x-stable #3723 +/- ##
==============================================
- Coverage 98.25% 98.25% -0.01%
==============================================
Files 1257 1257
Lines 74911 74914 +3
Branches 3567 3567
==============================================
+ Hits 73602 73604 +2
- Misses 1309 1310 +1 ☔ View full report in Codecov by Sentry. |
marcotc
approved these changes
Jun 28, 2024
Merged
ivoanjo
added a commit
that referenced
this pull request
Jul 3, 2024
**What does this PR do?** This PR is a follow-up on #3723. For the 1.23.3 dd-trace-rb release, we included a quite detailed post-install message to tell customers that the new release was out: ``` Thank you for installing ddtrace. We have released our next major version! As of version 2, `ddtrace` gem has been renamed to `datadog`. The 1.x series will now only receive maintenance updates for security and critical bug fixes. To upgrade, please replace gem `ddtrace` with gem `datadog`. For detailed instructions on migration, see: https://dtdg.co/ruby-v2-upgrade ``` My thinking is -- some customers may not be able to move to 2.x as quickly as they wanted, and thus seeing that message again and again may start to be slightly annoying. Thus, this PR replaces with with the minimalistic ``` The ddtrace gem has been renamed to datadog. We recommend upgrading: https://dtdg.co/ruby-v2-upgrade ``` **Motivation:** Continue suggesting to customers that the should upgrade, while at the same time not being too annoying about it. **Additional Notes:** It actually may not a half-bad idea that we released a version with the big message, and then shorted in. Specifically, customers that mostly keep up-to-date will probably see that message quite quickly, and thus upgrade. For the long tail of customers that may need to remain on 1.x, the more minimalistic message that will go out in a few weeks/months on a future 1.x maintenance release will continue to remind them. **How to test the change?** ```bash $ bundle exec rake build # ... ddtrace 1.23.3 built to pkg/ddtrace-1.23.3.gem. $ gem install pkg/ddtrace-1.23.3.gem Building native extensions. This could take a while... The ddtrace gem has been renamed to datadog. We recommend upgrading: https://dtdg.co/ruby-v2-upgrade ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?