Skip to content

Commit

Permalink
Use minimalistic post-install upgrade message
Browse files Browse the repository at this point in the history
**What does this PR do?**

This PR is a follow-up on #3723.

For the 1.23.3 dd-trace-rb release, we included a quite detailed
post-install message to tell customers that the new release was out:

```
Thank you for installing ddtrace. We have released our next major version!

As of version 2, `ddtrace` gem has been renamed to `datadog`.
The 1.x series will now only receive maintenance updates for security and critical bug fixes.

To upgrade, please replace gem `ddtrace` with gem `datadog`.
For detailed instructions on migration, see: https://dtdg.co/ruby-v2-upgrade
```

My thinking is -- some customers may not be able to move to 2.x as
quickly as they wanted, and thus seeing that message again and again may
start to be slightly annoying.

Thus, this PR replaces with with the minimalistic

```
The ddtrace gem has been renamed to datadog. We recommend upgrading: https://dtdg.co/ruby-v2-upgrade
```

**Motivation:**

Continue suggesting to customers that the should upgrade, while at the
same time not being too annoying about it.

**Additional Notes:**

It actually may not a half-bad idea that we released a version with the
big message, and then shorted in.

Specifically, customers that mostly keep up-to-date will probably see
that message quite quickly, and thus upgrade.

For the long tail of customers that may need to remain on 1.x, the
more minimalistic message that will go out in a few weeks/months on
a future 1.x maintenance release will continue to remind them.

**How to test the change?**

```bash
$ bundle exec rake build
 # ...

ddtrace 1.23.3 built to pkg/ddtrace-1.23.3.gem.

$ gem install pkg/ddtrace-1.23.3.gem
Building native extensions. This could take a while...
    The ddtrace gem has been renamed to datadog. We recommend upgrading: https://dtdg.co/ruby-v2-upgrade
```
  • Loading branch information
ivoanjo committed Jul 3, 2024
1 parent 4e33388 commit 0fe5d2c
Showing 1 changed file with 1 addition and 7 deletions.
8 changes: 1 addition & 7 deletions ddtrace.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -77,12 +77,6 @@ Gem::Specification.new do |spec|
spec.extensions = ['ext/datadog_profiling_native_extension/extconf.rb', 'ext/datadog_profiling_loader/extconf.rb']

spec.post_install_message = <<-MSG
Thank you for installing ddtrace. We have released our next major version!
As of version 2, `ddtrace` gem has been renamed to `datadog`.
The 1.x series will now only receive maintenance updates for security and critical bug fixes.
To upgrade, please replace gem `ddtrace` with gem `datadog`.
For detailed instructions on migration, see: https://dtdg.co/ruby-v2-upgrade
The ddtrace gem has been renamed to datadog. We recommend upgrading: https://dtdg.co/ruby-v2-upgrade
MSG
end

0 comments on commit 0fe5d2c

Please sign in to comment.