Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] fix heading elements are not in a sequentially-descending order #440

Merged
merged 1 commit into from
Jun 20, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion frontend/src/components/TableOfContents.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ export const TableOfContents: FC<TableOfContentsProps> = ({ header, items }) =>
</ListItemButton>
</ListItem>
))}
<Divider />
<Divider component="li" />
<ListItem disablePadding>
<ListItemButton
onClick={() => {
Expand Down
8 changes: 6 additions & 2 deletions frontend/src/components/TableOfContentsDialog.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,11 @@ export const TableOfContentsDialog: FC<TableOfContentsDialogProps> = ({ header,

return (
<>
<Fab aria-label={t('table-of-contents.dialog.trigger-aria-label')} onClick={handleOnTriggerClick} className='focus-visible:ring-4 focus-visible:ring-primary-500'>
<Fab
aria-label={t('table-of-contents.dialog.trigger-aria-label')}
onClick={handleOnTriggerClick}
className="focus-visible:ring-4 focus-visible:ring-primary-500"
>
<TocIcon />
</Fab>
<Dialog open={open} onClose={handleOnDialogClose} fullScreen={fullScreen}>
Expand All @@ -67,7 +71,7 @@ export const TableOfContentsDialog: FC<TableOfContentsDialogProps> = ({ header,
</ListItemButton>
</ListItem>
))}
<Divider />
<Divider component="li" />
<ListItem disablePadding>
<ListItemButton
onClick={() => {
Expand Down
10 changes: 5 additions & 5 deletions frontend/src/pages/learn/main-sources-of-retirement-income.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@ const MainSourcesOfRetirementIncome: FC = () => {
/>
</p>

<h4 className="h4 mb-4">{t('old-age-security-program.helpful-resources.header')}</h4>
<h3 className="h4 mb-4">{t('old-age-security-program.helpful-resources.header')}</h3>
<ul className="mb-5 list-disc space-y-1 pl-7">
{[
{
Expand Down Expand Up @@ -262,7 +262,7 @@ const MainSourcesOfRetirementIncome: FC = () => {
<p>{t('guaranteed-income-supplement.monthly')}</p>
<p>{t('guaranteed-income-supplement.collecting')}</p>

<h4 className="h4 mb-4">{t('guaranteed-income-supplement.helpful-resources.header')}</h4>
<h3 className="h4 mb-4">{t('guaranteed-income-supplement.helpful-resources.header')}</h3>
<ul className="mb-5 list-disc space-y-1 pl-7">
{[
{
Expand Down Expand Up @@ -308,7 +308,7 @@ const MainSourcesOfRetirementIncome: FC = () => {
/>
</p>

<h4 className="h4 mb-4">{t('canada-pension-plan-program.helpful-resources.header')}</h4>
<h3 className="h4 mb-4">{t('canada-pension-plan-program.helpful-resources.header')}</h3>
<ul className="mb-5 list-disc space-y-1 pl-7">
{[
{
Expand Down Expand Up @@ -389,9 +389,9 @@ const MainSourcesOfRetirementIncome: FC = () => {
/>
</p>

<h4 className="h4 mb-4">
<h3 className="h4 mb-4">
{t('canada-pension-plan-program.cpp-post-retirement-benefit.helpful-resources.header')}
</h4>
</h3>
<ul className="mb-5 list-disc space-y-1 pl-7">
{[
{
Expand Down
Loading