Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[frontend] fix heading elements are not in a sequentially-descending order #440

Merged
merged 1 commit into from
Jun 20, 2023
Merged

[frontend] fix heading elements are not in a sequentially-descending order #440

merged 1 commit into from
Jun 20, 2023

Conversation

sebastien-comeau
Copy link
Contributor

Description

List of proposed changes:

  • fix heading elements are not in a sequentially-descending order (accessiblity issue)

@sebastien-comeau sebastien-comeau requested a review from a team June 20, 2023 14:28
Fbasham
Fbasham approved these changes Jun 20, 2023
View reviewed changes
Copy link
Member

@Fbasham Fbasham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

screen readers will be happy

@sebastien-comeau sebastien-comeau merged commit b27033e into main Jun 20, 2023
3 checks passed
@sebastien-comeau sebastien-comeau deleted the fix-headings-order branch June 20, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fbasham Fbasham Fbasham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sebastien-comeau @Fbasham