This repository has been archived by the owner on Dec 26, 2022. It is now read-only.
feat(endpoint): Improve endpoint build instructions #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jserv
changed the title
marktwtn
reviewed
Jun 10, 2020
marktwtn
reviewed
Jun 10, 2020
marktwtn
reviewed
Jun 10, 2020
howjmay
suggested changes
Jun 10, 2020
splasky
force-pushed
the
591
branch
2 times, most recently
from
cf4edef
to
6a1fdee
Compare
jserv
reviewed
Jun 10, 2020
splasky
force-pushed
the
591
branch
3 times, most recently
from
aca7793
to
8b506e9
Compare
jserv
reviewed
Jun 11, 2020
jserv
reviewed
Jun 11, 2020
jserv
reviewed
Jun 11, 2020
jserv
reviewed
Jun 11, 2020
splasky
force-pushed
the
591
branch
3 times, most recently
from
6d1473e
to
6af9628
Compare
howjmay
suggested changes
Jun 15, 2020
splasky
force-pushed
the
591
branch
3 times, most recently
from
4fd9965
to
3cdc03e
Compare
jserv
reviewed
Jun 15, 2020
splasky
force-pushed
the
591
branch
2 times, most recently
from
21e3833
to
4818252
Compare
jserv
reviewed
Jun 20, 2020
jserv
reviewed
Jun 20, 2020
jserv
reviewed
Jun 20, 2020
splasky
force-pushed
the
591
branch
2 times, most recently
from
c46d81b
to
c7b244e
Compare
jserv
reviewed
Jun 22, 2020
splasky
force-pushed
the
591
branch
3 times, most recently
from
323ee43
to
081bc30
Compare
jserv
reviewed
Jun 22, 2020
Makefile
Outdated
| @@ -36,7 +52,15 @@ legato: cert | |||
| # which can not be downloaded when the 'fetch' option is used. | |||
| bazel --output_base=$(OUTPUT_BASE_DIR) build //endpoint:libendpoint.so | |||
| # Generate endpoint Legato app | |||
| (cd endpoint && leaf shell -c "mkapp -v -t wp77xx endpoint.adef") | |||
| ifeq ($(TARGET), development_host) | |||
There was a problem hiding this comment.
It must be space, not tab.
There was a problem hiding this comment.
By using define directives, you can customize commands which would be placed around here.
Check this: http://www.chiark.greenend.org.uk/doc/make-doc/make.html/Using-Variables.html
There was a problem hiding this comment.
For example, F9 microkernel invokes platform-specific flash command in flexible ways: https://github.com/f9micro/f9-kernel/blob/master/mk/generic.mk#L79
File platform/*/build.mk defines platform-flash-command accordingly.
There was a problem hiding this comment.
Always write down elegant and pretty code.
|
Check CI pipeline. |
howjmay
suggested changes
Jun 23, 2020
jserv
reviewed
Jun 23, 2020
jserv
reviewed
Jun 23, 2020
jserv
reviewed
Jun 23, 2020
marktwtn
suggested changes
Jun 23, 2020
This commit adds the build instructions for generating endpoint test or app with different target. For compatibility with legato framework, we use the GNU Make build system to build endpoint. Use "make legato" to generate endpoint app. The macro TARGET intends to the target platform. The default TARGET is the platform on your development host. Set the TARGET like TARGET=wp77xx to generate specific platform endpoint app. The macro ENABLE_ENDPOINT_TEST is for generating the endpoint app in test mode. Set ENABLE_ENDPOINT_TEST=true to enable generating test mode endpoint app. The endpoint uses the sierra framework as based runtime system. Developers need to set up the sierra development environment to build endpoint as specific target. See docs/endpoint.md for more information. Close DLTcollab#591
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the build instructions for generating endpoint test
or app with different target. For compatibility with legato framework,
we use the GNU Make build system to build endpoint. Use "make legato"
to generate endpoint app.
The macro TARGET intends to the target to generate. The default TARGET
is the platform on your development host. Set the TARGET like
TARGET=wp77xx to generate specific platform endpoint app.
The macro ENABLE_ENDPOINT_TEST is for generating the endpoint app in test mode.
Set ENABLE_ENDPOINT_TEST=true to enable generating test mode endpoint app.
The endpoint uses the sierra framework as based runtime system.
Developers need to set up the sierra development environment
to build endpoint as specific target. See docs/endpoint.md for
more information.
The default port has been modified to pass the test on buildkite.
Close #591