Skip to content
This repository has been archived by the owner on Dec 26, 2022. It is now read-only.

test(endpoint): Make Legato endpoint app to read the input #671

Closed
marktwtn opened this issue Jun 9, 2020 · 3 comments · Fixed by #677
Closed

test(endpoint): Make Legato endpoint app to read the input #671

marktwtn opened this issue Jun 9, 2020 · 3 comments · Fixed by #677
Assignees

Comments

@marktwtn
Copy link
Contributor

marktwtn commented Jun 9, 2020

Currently, we do not give any input to the Legato endpoint app.
To make sure the endpoint app would work well, the input should be passed to it.

Goal:
Implement the command line interface to pass the input to Legato endpoint app.

@marktwtn marktwtn self-assigned this Jun 9, 2020
@marktwtn
Copy link
Contributor Author

Although the main goal is to pass the input for testing, we are also considering that we can assign the ENDPOINT_HOST or ENDPOINT_PORT with the implementation.

However, I found it needs some effort:

  • The ENDPOINT_HOST is a macro, which is given during the build steps instead of executing steps.
  • The macro is used in the endpoint_core.c instead of endpoint.c. But the command line argument passing implementation is on the endpoint.c side.

c.c @splasky .

@marktwtn
Copy link
Contributor Author

In addition, if we would like to use the endpoint app command line option with the command app, the format would look like this:

$ app runProc endpoint --exe=endpoint -- --help

@splasky
Copy link
Contributor

splasky commented Jun 13, 2020

Although the main goal is to pass the input for testing, we are also considering that we can assign the ENDPOINT_HOST or ENDPOINT_PORT with the implementation.

However, I found it needs some effort:

  • The ENDPOINT_HOST is a macro, which is given during the build steps instead of executing steps.
  • The macro is used in the endpoint_core.c instead of endpoint.c. But the command line argument passing implementation is on the endpoint.c side.

c.c @splasky .

I think it is better to set the endpoint and host when app start at the beginning. Remove the ENDPOINT_HOST and ENDPOINT_PORT if you can set the host and port at executing steps.

marktwtn added a commit that referenced this issue Jun 17, 2020
The arguments of the endpoint core function
send_transaction_information() can be passed with the command line.

Close #671.
marktwtn added a commit that referenced this issue Jun 17, 2020
The arguments of the endpoint core function
send_transaction_information() can be passed with the command line.

Close #671.
marktwtn added a commit that referenced this issue Jun 17, 2020
The arguments of the endpoint core function
send_transaction_information() can be passed with the command line.

Close #671.
marktwtn added a commit that referenced this issue Jun 17, 2020
The arguments of the endpoint core function
send_transaction_information() can be passed with the command line.

Close #671.
marktwtn added a commit that referenced this issue Jun 17, 2020
The arguments of the endpoint core function
send_transaction_information() can be passed with the command line.

Close #671.
marktwtn added a commit that referenced this issue Jun 17, 2020
The arguments of the endpoint core function
send_transaction_information() can be passed with the command line.

Close #671.
marktwtn added a commit that referenced this issue Jun 18, 2020
The arguments of the endpoint core function
send_transaction_information() can be passed with the command line.

Close #671.
marktwtn added a commit that referenced this issue Jun 19, 2020
The arguments of the endpoint core function
send_transaction_information() can be passed with the command line.

Close #671.
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants