Pre-release v0.6.0 #223
Merged
Pre-release v0.6.0 #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original ddprintf() function name is changed to the similar function log_debug() in entangled. The implementation is unchanged since the dcurl does not integrate with the logger project used by entangled. Currently dcurl has its own implementation. For unification, the logger_id_t logger_id parameter of log_debug() is added and assigned with 0. And there is a new log function log_info() for release mode. Close #180.
refactor: Change log function for unification with entangled
The detected and fixed errors list: - Assign a value that is never used - Reassign a value before the old one has been used - The scope of the variable can be reduced - The behaviour of using void pointers in calculations is undefined - Uninitialized variable - Shadow variables The file cppcheck_suppress suppresses the errors which should not be treated as errors. The reason is written in the file. The sanitizer.mk is renamed as dynamic-analysis.mk. And there is another file static-analysis.mk for static code analysis. Related to #173.
Cppcheck integration
The detected and fixed errors are: - Memory leak - Null pointer dereference Close #173.
CI: Integrate Infer and fix detected errors
The functions of local and remote interface should be unified to keep consistency. The modification includes function unification and adding the hardware to the candidate list if the initialization is success.
If the remote interface is not initialized succesfully, the other hardwares would be used to calculate PoW. The checking mechanism is based on the record in the initiailzation phase. Close #186.
Initialization rework
CI: Build with arm64 CPU on Travis CI
The source code files are renamed to the same format. The word 'accel' is removed from the files and variables naming.
refactor: Rename files and FPGA related variables
Declare queue in the remote worker source code to avoid queue missing error when the new RabbitMQ broker is created and the remote worker is activated right after it. Close #209.
fix: Avoid queue missing error
Besides the source code unification, the related document is added for the naming convention details. Close #207.
Apply consistent naming scheme
fix: Add brackets to avoid unexpected macro behavior
Use the CppCheck --inline-suppr option to suppress the detected warnings by adding the corresponding comment in the source code. The previous method needs to specify the source code line number in the suppression file, which is less flexible to maintain. Close #215.
CI: Suppress CppCheck warning with --inline-suppr option
docs: Update dcurl performance data
docs: Add the steps of setting MAC address of DE10-Nano
refactor: Replace port number with pre-defined macro
The dcurl_init API can pass a pointer to enable initialization configuration. Currently it only sets the hostname of the broker. If the passed pointer is NULL, the pre-defined default value would be used. The API document description and the test cases are modified as well. Close #220.
feat: Change dcurl_init API to enable initialization configuration
v0.6.0🎉 New Features
🐛 Bug Fixes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.