Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify the naming convention with snake case #207

Closed
marktwtn opened this issue Nov 30, 2019 · 0 comments · Fixed by #213
Closed

Unify the naming convention with snake case #207

marktwtn opened this issue Nov 30, 2019 · 0 comments · Fixed by #213
Assignees
@marktwtn

Comments

@marktwtn
Copy link
Collaborator

The variable and function naming is messy.
One might use camel case, and another might use snake case and sometimes the other might use upper camel case.

In the future, the dcurl may be integrated into entangled.
We should follow the same naming convention, which is snake case in my observation.
@marktwtn marktwtn self-assigned this Nov 30, 2019
marktwtn added a commit that referenced this issue Jan 3, 2020
@marktwtn
style: Unify the naming convention with snake case
7a43ae3 
Besides the source code unification, the related document is added
for the naming convention details.

Close #207.
@marktwtn marktwtn mentioned this issue Jan 3, 2020
Merged
marktwtn added a commit that referenced this issue Jan 3, 2020
@marktwtn
style: Unify the naming convention with snake case
ec198fe 
Besides the source code unification, the related document is added
for the naming convention details.

Close #207.
marktwtn added a commit that referenced this issue Jan 3, 2020
@marktwtn
style: Unify the naming convention with snake case
beddc39 
Besides the source code unification, the related document is added
for the naming convention details.

Close #207.
@jserv jserv closed this as completed in #213 Jan 3, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marktwtn marktwtn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Naming convention DLTcollab/dcurl
1 participant
@marktwtn