Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add skeleton for product support SLE Micro OS with name slmicro5 #12028

Merged
merged 8 commits into from
Jul 10, 2024
Merged

Add skeleton for product support SLE Micro OS with name slmicro5 #12028

merged 8 commits into from
Jul 10, 2024

Conversation

teacup-on-rockingchair
Copy link
Contributor

@teacup-on-rockingchair teacup-on-rockingchair commented May 28, 2024 •
edited
Loading

Description:

  • Add support for SUSE Linux Enterprise MicroOS product with target name slmicro5

Rationale:

  • Add required definitions to support slmicro5 product
  • The name was chosen with the idea that although it is a SLE(SUSE Linux Enterprise) product it has different behaviour than sle12 and sle15 platforms and should be considered part of new multi_platform slmicro, designated for all SUSE Linux Enterprise MicroOS products.
Internals
  • Add skeleton for product support SLE Micro OS
  • Add manual DISA STIG for slmicro5 as reference
  • Add stig control file for DISA STIG profile
  • Add rule installed_OS_is_vendor_supported

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Used by openshift-ci bot. label May 28, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 28, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@github-actions GitHub Actions
Copy link

github-actions bot commented May 28, 2024 •
edited
Loading

Start a new ephemeral environment with changes proposed in this pull request:

rhel8 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@github-actions GitHub Actions
Copy link

github-actions bot commented May 28, 2024 •
edited
Loading

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:12028
This image was built from commit: 96606f8

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:12028

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:12028 make deploy-local

@teacup-on-rockingchair
Add skeleton for product support SLE Micro OS
d232f4a
@teacup-on-rockingchair
Add rule installed_OS_is_vendor_supported
9da0137
@teacup-on-rockingchair
Rename slemicro to susemicro5
f50b52c 
Thus achieveing several goals:
- Avoid checks in jinja if *sle* in platform, when assuming sle12 or sle15
- Current SUSE Linux Enterprise MicroOS support targets only major version 5 of the platfom so SLE MicroOS v6 and above is target to future developments
- Due to confusion in platfrom multi_platform checks the installed_OS_is check was failiing to compile fully
@teacup-on-rockingchair
Add manual DISA STIG for susemicro5 as reference
7975614
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 1, 2024 •
edited
Loading

This datastream diff is auto generated by the check Compare DS/Generate Diff

Click here to see the full diff 
OVAL for rule 'xccdf_org.ssgproject.content_rule_installed_OS_is_vendor_supported' differs.
--- oval:ssg-installed_OS_is_vendor_supported:def:1
+++ oval:ssg-installed_OS_is_vendor_supported:def:1
@@ -5,3 +5,4 @@
 extend_definition oval:ssg-installed_OS_is_ol8:def:1
 extend_definition oval:ssg-installed_OS_is_sle12:def:1
 extend_definition oval:ssg-installed_OS_is_sle15:def:1
+extend_definition oval:ssg-installed_OS_is_slmicro5:def:1

@teacup-on-rockingchair teacup-on-rockingchair changed the title Add skeleton for product support SLE Micro OS Add skeleton for product support SLE Micro OS with name susemicro5 Jul 1, 2024
@teacup-on-rockingchair teacup-on-rockingchair marked this pull request as ready for review July 2, 2024 06:45
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Used by openshift-ci bot. label Jul 2, 2024
@teacup-on-rockingchair teacup-on-rockingchair marked this pull request as draft July 2, 2024 08:10
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Used by openshift-ci bot. label Jul 2, 2024
@teacup-on-rockingchair teacup-on-rockingchair changed the title Add skeleton for product support SLE Micro OS with name susemicro5 Add skeleton for product support SLE Micro OS with name slmicro5 Jul 2, 2024
@teacup-on-rockingchair teacup-on-rockingchair marked this pull request as ready for review July 2, 2024 12:12
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Used by openshift-ci bot. label Jul 2, 2024
@teacup-on-rockingchair teacup-on-rockingchair requested review from dodys and jan-cerny and removed request for dodys July 3, 2024 11:45
@jan-cerny jan-cerny self-assigned this Jul 4, 2024
@jan-cerny jan-cerny added this to the 0.1.74 milestone Jul 4, 2024
jan-cerny
jan-cerny reviewed Jul 4, 2024
View reviewed changes
Copy link
Collaborator

@jan-cerny jan-cerny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so far looks great

...s/guide/system/software/integrity/certified-vendor/installed_OS_is_vendor_supported/rule.yml
@@ -34,6 +34,7 @@ identifiers:
cce@rhel9: CCE-83453-1
cce@sle12: CCE-83001-8
cce@sle15: CCE-83260-0
cce@slmicro5: CCE-93601-3
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will there be a CCE pool file, similar to shared/references/cce-sle15-avail.txt?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For sure there is a pending PR #12109 on me for that, that I will review/merge as soon as the current one is approved

products/slmicro5/profiles/stig.profile Outdated

reference: https://public.cyber.mil/stigs/downloads/?_dl_facet_stigs=operating-systems%2Cunix-linux

title: 'SUSE Linux Enterprise Micro (SLEM) 5'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be STIG in the profile title

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks added in 96606f8

@codeclimate CodeClimate
Copy link

codeclimate bot commented Jul 5, 2024

Code Climate has analyzed commit 96606f8 and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 2

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.4% (0.0% change).

View more on Code Climate.

jan-cerny
jan-cerny approved these changes Jul 10, 2024
View reviewed changes
Copy link
Collaborator

@jan-cerny jan-cerny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have built the slmicro5 product. I have seen the built data stream. I have also read the generated HTML guide for STIG.

@jan-cerny
Copy link
Collaborator

The CI fail isn't caused by the contents of this PR. The Code Climate problem is a false positive.

@jan-cerny jan-cerny merged commit 46555a6 into ComplianceAsCode:master Jul 10, 2024
90 of 94 checks passed
@Mab879 Mab879 added the New Product Issues or pull requests related to new Products. label Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jan-cerny jan-cerny jan-cerny approved these changes

@dodys dodys Awaiting requested review from dodys

Assignees

@jan-cerny jan-cerny

Labels
New Product Issues or pull requests related to new Products.
Projects
None yet
Milestone
0.1.74
Development

Successfully merging this pull request may close these issues.
3 participants
@teacup-on-rockingchair @jan-cerny @Mab879