Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add openembedded distro support #10793

Merged
merged 4 commits into from
Aug 25, 2023
Merged

Conversation

akuster
Copy link
Contributor

@akuster akuster commented Jul 3, 2023

includes a standard profile for out-of-the-box checks

Description:

This enables support for an OpenEmbedded based system. OpenEmbedded is a Framework for building a custom distribution. One such distribution is the Yocto Project's "Poky reference distribution". Openscap and scap-security-guide are part of a security layer I maintain which allows users to add security applications to their builds.

Rationale:

In the spirit of opensource I am upstream my changes. I am not sure if this meet the intent or objective of the project. I wanted to included a baseline set of tests that pass if run on on a default build.

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Jul 3, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jul 3, 2023

Hi @akuster. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions
Copy link

github-actions bot commented Jul 3, 2023

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@Mab879 Mab879 added the New Product Issues or pull requests related to new Products. label Jul 5, 2023
@akuster
Copy link
Contributor Author

akuster commented Jul 7, 2023

Hello, I see there is a test-cmakelint error. I take it I need to correct that and do a v2 on the pull request?

includes a standard profile for out-of-the-box checks

Signed-off-by: Armin Kuster <akuster808@gmail.com>

[v2]
Fix cmakelint error
@Mab879 Mab879 self-assigned this Jul 19, 2023
@Mab879 Mab879 added this to the 0.1.70 milestone Jul 19, 2023
Copy link
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay in review. One additional question we have is your plans on keeping this updated.

Thanks for the PR.

CMakeLists.txt Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
akuster and others added 3 commits August 23, 2023 12:29
Use the formal name, not abbreviation.

Co-authored-by: Matthew Burket <m@tthewburket.com>
Co-authored-by: Matthew Burket <m@tthewburket.com>
Co-authored-by: Matthew Burket <m@tthewburket.com>
@akuster
Copy link
Contributor Author

akuster commented Aug 23, 2023

No worries. I plan on keeping it updated. I was waiting to see if these changes where going to be accepted before sending additional changes.

thanks

@codeclimate
Copy link

codeclimate bot commented Aug 25, 2023

Code Climate has analyzed commit e2e5226 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 53.3%.

View more on Code Climate.

Copy link
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Thanks for the PR!

@Mab879 Mab879 merged commit 5a89c8c into ComplianceAsCode:master Aug 25, 2023
36 of 37 checks passed
@Mab879 Mab879 added the Highlight This PR/Issue should make it to the featured changelog. label Aug 25, 2023
@Mab879 Mab879 changed the title scap-security-guide: add openembedded distro support Add openembedded distro support Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Highlight This PR/Issue should make it to the featured changelog. needs-ok-to-test Used by openshift-ci bot. New Product Issues or pull requests related to new Products.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants