fix: --ignore_dir now work as expected #207
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gosuwachu
force-pushed
the
fix-ignore-dirs
branch
from
3f8528e
to
3de0144
Compare
gosuwachu
force-pushed
the
fix-ignore-dirs
branch
from
3de0144
to
e2d5a34
Compare
gosuwachu
changed the title
gosuwachu
changed the title
|
ping, in case you have missed this @Byron :) |
Also add more debugging information to the log, and allow `debug` logging to show up in there. While at it, assure that performance won't be affected too strongly when a lot of directories are used by using a set instead.
Byron
approved these changes
Jan 3, 2024
There was a problem hiding this comment.
Thanks a lot for getting this fix started, and sorry for the delay! I must have archived the 'ready for review' email by mistake, and thus failed to follow up.
With that said, it seems to work now and performance with the usage of ignore-dirs seems acceptable. While I can imagine ways to improve performance, I didn't profile it yet. Thus, let's fix the bug first and then see if there are issues with performance later.
|
Closing, as the commits are merged but GitHub can't detect it due to my most recent changes to the patch queue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #196. Paths and ignore directories are canonicalized before comparison. E.g. this now works as expected: