-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple dirs in --ignore-dirs not working as expected #196
Comments
Thanks a lot for letting me know! Indeed, it doesn't seem to work at all and I could reproduce it well. If it's that broken, and was at some point deemed working, maybe a test is missing for it as well. |
I've never tried ignore before with dua so do not know if it ever worked :). Thanks for looking into it! |
@edrozenberg This looks to work as expected. To pass multiple ignore directories you have to specify them separately, like this:
|
Thanks but this does not work as expected, still getting an incorrect double-counted result:
|
I think I know where this bug is coming from. Try this instead:
|
Thanks this seems to work fine, but it shouldn't because if I don't include the
|
Thanks everyone for chiming in and for helping to solve this puzzle! I can confirm that I think in order to resolve this, |
Previously they would need to be specified as relative to the traversal root, which was unintuitive and would lead to ignores not working for many. Even though this was done for performance to avoid canonicalization, we do now perform a more performance version of canonicalization so the overall performance should be acceptable nonetheless. Also note that ignored directories are now logged when using a `--log-file`.
This should be fixed with the latest release, and I wasn't able to reproduce the issue anymore with the new version either. Please let us know if the issue persists. |
I'm comparing gdu results (correct) with dua results (incorrect) when excluding multiple dirs on MacOS. I'm excluding these specific dirs in order to avoid the double-counting caused by how Apple has decided to mount, alias, and symlink various items in /System.
My Mac drive is a 1 TB with ~ 330 GB free atm, so gdu is correct showing ~600 GB used, while dua shows ~1.2TB used due to the double counting.
My GDU command:
sudo gdu-go -i /System/Volumes/Data/Volumes,/System/Volumes/Data /
My DUA command:
sudo dua -i /System/Volumes/Data/Volumes,/System/Volumes/Data interactive /
And reported disk use from
df
:The text was updated successfully, but these errors were encountered: