Dev/sl google java format15 #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'core/**/*.java',
'docs/**/*.java',
'doctest/**/*.java',
'relase-notes/**/*.java',
'spark/**/*.java'
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
MitchellGale
requested review from
MaxKsyunz,
Yury-Fridlyand,
forestmvey,
acarbonetto and
GumpacG
as code owners
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Yury-Fridlyand
approved these changes
Aug 16, 2023
Comment on lines
+90
to
+92
| 'docs/**/*.java', | ||
| 'doctest/**/*.java', | ||
| 'relase-notes/**/*.java', |
| @ToString.Include | ||
| private SparkQueryRequest request; | ||
|
|
||
| @EqualsAndHashCode.Include @Getter @Setter @ToString.Include private SparkQueryRequest request; |
|
Please, update PR title and description |
Codecov Report
@@ Coverage Diff @@
## integ/sl_GoogleJavaFormat15 #341 +/- ##
==============================================================
Coverage 97.51% 97.51%
Complexity 4656 4656
==============================================================
Files 408 408
Lines 11932 11932
Branches 829 829
==============================================================
Hits 11636 11636
Misses 289 289
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
MitchellGale
merged commit 9718680
into
integ/sl_GoogleJavaFormat15
15 of 16 checks passed
matthewryanwells
pushed a commit
that referenced
this pull request
Aug 17, 2023
…pensearch-project#1975) * Dev/sl google java format15 (#341) * Spotless apply on 'datasources/**/*.java', 'core/**/*.java', 'docs/**/*.java', 'doctest/**/*.java', 'relase-notes/**/*.java', 'spark/**/*.java' Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * Added more directories to build.gradle Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * spotless apply for plugin. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * Adding checkstyle ignorefailures. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> --------- Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * added missing semi colon. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * Update build.gradle Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com> Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com> * Update build.gradle Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com> * Update build.gradle Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com> --------- Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com> Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com>
MitchellGale
added a commit
that referenced
this pull request
Aug 22, 2023
…pensearch-project#1975) * Dev/sl google java format15 (#341) * Spotless apply on 'datasources/**/*.java', 'core/**/*.java', 'docs/**/*.java', 'doctest/**/*.java', 'relase-notes/**/*.java', 'spark/**/*.java' Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * Added more directories to build.gradle Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * spotless apply for plugin. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * Adding checkstyle ignorefailures. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> --------- Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * added missing semi colon. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * Update build.gradle Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com> Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com> * Update build.gradle Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com> * Update build.gradle Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com> --------- Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com> Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[Describe what this change achieves]
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.