Driver timestamp #15
Merged
Driver timestamp #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 9, 2021 14:24
Signed-off-by: Guian Gumpac <guiang@bitquilltech.com>
Signed-off-by: Guian Gumpac <guiang@bitquilltech.com>
ghost
requested review from
kylepbit
reviewed
Dec 10, 2021
| @@ -86,7 +86,7 @@ const std::unordered_map< std::string, int > data_name_data_type_map = { | |||
| {OPENSEARCH_TYPE_NAME_SCALED_FLOAT, SQL_DOUBLE}, | |||
| {OPENSEARCH_TYPE_NAME_KEYWORD, SQL_WVARCHAR}, | |||
| {OPENSEARCH_TYPE_NAME_TEXT, SQL_WVARCHAR}, | |||
| {OPENSEARCH_TYPE_NAME_DATE, SQL_TYPE_TIMESTAMP}, | |||
| {OPENSEARCH_TYPE_NAME_TIMESTAMP, SQL_TYPE_TIMESTAMP}, | |||
There was a problem hiding this comment.
Shouldn't you keep the date mapping to timestamp here as well?
kylepbit
reviewed
Dec 10, 2021
| @@ -372,7 +372,7 @@ opensearchtype_attr_to_sqldesctype(const ConnectionClass *conn, OID type, int ty | |||
| case SQL_TYPE_DATE: | |||
| case SQL_TYPE_TIME: | |||
| case SQL_TYPE_TIMESTAMP: | |||
| return SQL_DATETIME; | |||
| return SQL_TYPE_TIMESTAMP; | |||
There was a problem hiding this comment.
I am not sure this is correct, I believe SQL_DATETIME is the correct return here?
added 2 commits
December 10, 2021 10:41
Signed-off-by: Guian Gumpac <guiang@bitquilltech.com>
Signed-off-by: Guian Gumpac <guiang@bitquilltech.com>
kylepbit
approved these changes
Dec 14, 2021
matthewryanwells
pushed a commit
that referenced
this pull request
Aug 17, 2023
…pensearch-project#1975) * Dev/sl google java format15 (#341) * Spotless apply on 'datasources/**/*.java', 'core/**/*.java', 'docs/**/*.java', 'doctest/**/*.java', 'relase-notes/**/*.java', 'spark/**/*.java' Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * Added more directories to build.gradle Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * spotless apply for plugin. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * Adding checkstyle ignorefailures. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> --------- Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * added missing semi colon. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * Update build.gradle Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com> Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com> * Update build.gradle Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com> * Update build.gradle Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com> --------- Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com> Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com>
MitchellGale
added a commit
that referenced
this pull request
Aug 22, 2023
…pensearch-project#1975) * Dev/sl google java format15 (#341) * Spotless apply on 'datasources/**/*.java', 'core/**/*.java', 'docs/**/*.java', 'doctest/**/*.java', 'relase-notes/**/*.java', 'spark/**/*.java' Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * Added more directories to build.gradle Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * spotless apply for plugin. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * Adding checkstyle ignorefailures. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> --------- Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * added missing semi colon. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * Update build.gradle Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com> Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com> * Update build.gradle Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com> * Update build.gradle Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com> --------- Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com> Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues Resolved
https://github.com/opensearch-project/sql/issues/317
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.