v11.0.0 #326
Merged
v11.0.0 #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
jhendrixMSFT
force-pushed
the
tokenmarshal
branch
from
1924a39
to
cc7d4d2
Compare
|
Fixes #325 |
marstr
suggested changes
Sep 28, 2018
| ExpiresIn string `json:"expires_in"` | ||
| ExpiresOn string `json:"expires_on"` | ||
| NotBefore string `json:"not_before"` | ||
| ExpiresIn json.Number `json:"expires_in"` |
There was a problem hiding this comment.
It may be a good moment to add some documentation about the expected contents of these values as well.
For example, I believe this is a whole number of seconds. We should say so :)
There was a problem hiding this comment.
I've added a link to the docs for this type.
autorest/adal/token_test.go
Outdated
| @@ -868,7 +862,7 @@ func expireToken(t *Token) *Token { | |||
|
|
|||
| func setTokenToExpireAt(t *Token, expireAt time.Time) *Token { | |||
| t.ExpiresIn = "3600" | |||
| t.ExpiresOn = strconv.Itoa(int(expireAt.Sub(date.UnixEpoch()).Seconds())) | |||
| t.ExpiresOn = json.Number(strconv.Itoa(int(expireAt.Sub(date.UnixEpoch()).Seconds()))) | |||
There was a problem hiding this comment.
I'd change this to
t.ExpiresOn = json.Number(fmt.Sprintf(int64(expireAt.Sub(date.UnixEpoch()) / time.Second)))While it's not any more readable, it has two advantages IMHO:
- Not calling
.Seconds()prevents the conversion from aninttype to afloattype. - Using
fmt.Sprintf()instead ofstrconv.Itoa()prevents us from casting down from 64 bits to 32 bits.
There was a problem hiding this comment.
Errr, I see this is just a test file so don't see this comment as too blocking or anything.
There was a problem hiding this comment.
I tweaked this a bit.
Changed a few fields in adal.Token from string to json.Number to handle differences between AAD and ADFS in how they send data over the wire. Added auth.NewAuthorizerFromFileWithResource to create an authorizer from the config file with the specified resource. Setting a client's PollingDuration to zero will use the provided context to control a LRO's polling duration.
jhendrixMSFT
force-pushed
the
tokenmarshal
branch
from
38aa960
to
063a7bf
Compare
|
Fixes #314 |
Closed
4 tasks
marstr
approved these changes
Sep 28, 2018
This was referenced Aug 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed a few fields in adal.Token from string to json.Number to handle
differences between AAD and ADFS in how they send data over the wire.
Added auth.NewAuthorizerFromFileWithResource to create an authorizer
from the config file with the specified resource.
Setting a client's PollingDuration to zero will use the provided context
to control a LRO's polling duration.
Thank you for your contribution to Go-AutoRest! We will triage and review it as soon as we can.
As part of submitting, please make sure you can make the following assertions:
devbranch, except in the case of urgent bug fixes warranting their own release.master, I've updated CHANGELOG.md to address the changes I'm making.