Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin utfbom and go-homedir to v1.0.0 and remove the explicit dependency on x/crypto master #320

Closed
wants to merge 2 commits into from

Conversation

ultimateboy
Copy link

@ultimateboy ultimateboy commented Sep 12, 2018

I ran into some issues today with a build pipeline that has this project as a dependency. Some changes to x/crypto weren't valid with some of my other dependencies, and the explicit pinning to master here causes pain upstream (having to use dep overrides). I don't see any reason why go-autorest needs to always be pinned to master, so I've removed this - dep will use the most recent valid version it can.

While I was at it, I also added specific versions (v1.0.0) for utfbom and go-homedir.

None of these changes actually change the dependencies in any way, as seen with the simple diff on the Gopkg.lock file. This just helps other repos which import this project.

As for checking the boxes that this is an "urgent bug fix" and warrants its own release, that's up to you - I altered the changelog in a separate commit. But given this is dealing with how projects import go-autorest, I think it would be prudent to tag a patch release with these changes.


As part of submitting, please make sure you can make the following assertions:

  • I've tested my changes, adding unit tests if applicable.
  • I've added Apache 2.0 Headers to the top of any new source files.
  • I'm submitting this PR to the dev branch, except in the case of urgent bug fixes warranting their own release.
  • If I'm targeting master, I've updated CHANGELOG.md to address the changes I'm making.

@jhendrixMSFT
Copy link
Member

Sorry for the delay on this, I've rolled your changes into #326.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants