Update dependencies #2270
Merged
Update dependencies #2270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeharder
requested review from
AlexGhiondea,
ramya-rao-a,
ramya0820 and
KarishmaGhiya
KarishmaGhiya
approved these changes
Apr 16, 2019
HarshaNalluru
approved these changes
Apr 16, 2019
| @@ -46,7 +46,7 @@ | |||
| "mocha": "^5.2.0", | |||
| "mocha-junit-reporter": "^1.18.0", | |||
| "mocha-multi": "^1.0.1", | |||
| "nyc": "^13.3.0", | |||
| "nyc": "^14.0.0-rc.1", | |||
There was a problem hiding this comment.
Reminder:
Once this is merged, please create an issue to update ^14.0.0-rc.1 to ^14.0.0
There was a problem hiding this comment.
The issue should refer to all of the packages we changed.
There was a problem hiding this comment.
NYC 14.0.0 was released last night so I am updating this PR, and I don't think we need a follow-up issue unless you disagree @AlexGhiondea. I'm not sure what you mean by "issue should refer to all of the packages we changed".
AlexGhiondea
approved these changes
Apr 16, 2019
ramya-rao-a
approved these changes
Apr 16, 2019
- Also convert tabs to spaces per style guidelines
This reverts commit a00a84f.
mikeharder
force-pushed
the
mikeharder/update-dependencies
branch
from
3b42b77
to
7da89e5
Compare
This was referenced May 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update versions of dev dependencies
nycandtslintCC: @Azure/azure-sdk-eng