-
Notifications
You must be signed in to change notification settings - Fork 16
Conversation
lib/ConnectionContextBase.ts
Outdated
@@ -140,7 +140,7 @@ export module ConnectionContextBase { | |||
const userAgent = parameters.connectionProperties.userAgent; | |||
if (userAgent.length > Constants.maxUserAgentLength) { | |||
throw new Error( | |||
`The user-agent string cannot be more than 128 characters in length.` + | |||
`The user-agent string cannot be more than 512 characters in length.` + |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets use the constant maxUserAgentLength
here instead of hard coding 512.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right after creating the connectionOptions
object lets use log
to log the same.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's also update the version number so we can release the next version today
@ramya-rao-a As discussed offline we will add a log for all the connection properties after successfully creating a connection in EventHubs. |
@ShivangiReja Azure/azure-sdk-for-js#2270 was the fix done in the main repo to fix the auditing issue. |
@ramya-rao-a , @ShivangiReja : PR to update dependencies: #43 |
… userAgentLenth
Description
Brief description of the changes made in the PR. This helps in making better change log
Reference to any github issues