Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hyperlinks and updated package version #58

Merged
merged 9 commits into from
Feb 22, 2024

Conversation

rdheekonda
Copy link
Contributor

Description

  • Fix hyperlinks
  • Updated package version as per pyproject.toml

Tests

  • no new tests required
  • new tests added
  • existing tests adjusted

Documentation

  • no documentation changes needed
  • documentation added or edited
  • example notebook added or updated

@romanlutz
Copy link
Contributor

Thanks for discovering AND fixing this issue.

I'm worried about versioning. I don't have a solution at this point, but if I am using version X and using a notebook from that version, then the notebook should link me to the corresponding notebooks of that version, not the latest main notebooks.

Copy link
Contributor

@romanlutz romanlutz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh my, you found a lot of them! Thanks a ton!

pyrit/__init__.py Show resolved Hide resolved
doc/setup/install_pyrit.md Outdated Show resolved Hide resolved
doc/how_to_guide.pct.py Outdated Show resolved Hide resolved
doc/how_to_guide.pct.py Outdated Show resolved Hide resolved
Co-authored-by: Roman Lutz <romanlutz13@gmail.com>
@rdheekonda
Copy link
Contributor Author

Thanks for discovering AND fixing this issue.

I'm worried about versioning. I don't have a solution at this point, but if I am using version X and using a notebook from that version, then the notebook should link me to the corresponding notebooks of that version, not the latest main notebooks.

Thanks for discovering AND fixing this issue.

I'm worried about versioning. I don't have a solution at this point, but if I am using version X and using a notebook from that version, then the notebook should link me to the corresponding notebooks of that version, not the latest main notebooks.

That's a good point, let me see whether I can reduce the full URL and provide relative paths to the current version notebooks.

doc/how_to_guide.pct.py Outdated Show resolved Hide resolved
doc/how_to_guide.ipynb Outdated Show resolved Hide resolved
doc/how_to_guide.pct.py Outdated Show resolved Hide resolved
@rdheekonda
Copy link
Contributor Author

Thanks for discovering AND fixing this issue.

I'm worried about versioning. I don't have a solution at this point, but if I am using version X and using a notebook from that version, then the notebook should link me to the corresponding notebooks of that version, not the latest main notebooks.

Wherever possible, I have included references to relative paths, so we should be set for the time being.

@rdheekonda rdheekonda closed this Feb 22, 2024
@rdheekonda rdheekonda reopened this Feb 22, 2024
@rdheekonda rdheekonda merged commit 061bcf3 into Azure:main Feb 22, 2024
4 checks passed
@romanlutz romanlutz mentioned this pull request Feb 22, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants