Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release instructions #57

Merged
merged 11 commits into from
Feb 28, 2024

Conversation

romanlutz
Copy link
Contributor

Description

Adding instructions for creating a new release.

Tests

  • no new tests required
  • new tests added
  • existing tests adjusted

Documentation

  • no documentation changes needed
  • documentation added or edited
  • example notebook added or updated

Copy link
Contributor

@nina-msft nina-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Peppering with questions that come to mind - take or leave whether to add more information into markdown but I tried to highlight what I'd ask about!

doc/contributing.md Show resolved Hide resolved
doc/contributing.md Show resolved Hide resolved
doc/contributing.md Outdated Show resolved Hide resolved
doc/contributing.md Show resolved Hide resolved
doc/contributing.md Show resolved Hide resolved
Copy link
Contributor

@rlundeen2 rlundeen2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nina has valid points, still good docs even if we clarify these later

doc/contributing.md Outdated Show resolved Hide resolved
doc/contributing.md Outdated Show resolved Hide resolved
doc/contributing.md Outdated Show resolved Hide resolved
doc/contributing.md Outdated Show resolved Hide resolved
doc/contributing.md Show resolved Hide resolved
Copy link
Contributor

@nina-msft nina-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but looks like you now have feedback from christian too :)

@romanlutz romanlutz merged commit a91a5ad into Azure:main Feb 28, 2024
4 checks passed
@romanlutz romanlutz deleted the romanlutz/add_release_instructions branch February 28, 2024 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants