Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated dependencies #64

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

InoMurko
Copy link

As per #63 this is the minimal code change for dependency upgrade, including support for elixir 1.6 by downgrading exdoc.

test/websockex_test.exs Show resolved Hide resolved
test/support/test_server.ex Outdated Show resolved Hide resolved
.tool-versions Outdated Show resolved Hide resolved
test/websockex_test.exs Show resolved Hide resolved
@InoMurko
Copy link
Author

@Azolo I applied some changes, please take another look when you can.

@Azolo
Copy link
Owner

Azolo commented Dec 2, 2018

I'm really bothered about taking the tests out.

If you don't mind me taking a look and seeing how I could implement them with Cowboy 2.0.

But I really do appreciate the upgrading of Cowboy. 😄

@InoMurko
Copy link
Author

InoMurko commented Dec 3, 2018

I've added another commit, upgrading cowboy to 2.6.

To regards to the test you're referring to... The test used to use the returned req object that exposed access to the socket. The new req object currently looks like:
https://ninenines.eu/docs/en/cowboy/2.6/manual/cowboy_req/

req() :: #{
    method  := binary(),               %% case sensitive
    version := cowboy:http_version() | atom(),
    scheme  := binary(),               %% lowercase; case insensitive
    host    := binary(),               %% lowercase; case insensitive
    port    := inet:port_number(),
    path    := binary(),               %% case sensitive
    qs      := binary(),               %% case sensitive
    headers := cowboy:http_headers(),
    peer    := {inet:ip_address(), inet:port_number()},
    sock    := {inet:ip_address(), inet:port_number()},
    cert    := binary() | undefined
}

None of which allow you to upgrade the current connection manually.

@InoMurko
Copy link
Author

Ping.

@Azolo
Copy link
Owner

Azolo commented Feb 21, 2019

Hey, sorry been swamped. I'll set a reminder to take another look at this next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants