-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated dependencies #64
base: master
Are you sure you want to change the base?
Conversation
f2142fa
to
53b3359
Compare
0290522
to
7dc7d2c
Compare
@Azolo I applied some changes, please take another look when you can. |
I'm really bothered about taking the tests out. If you don't mind me taking a look and seeing how I could implement them with Cowboy 2.0. But I really do appreciate the upgrading of Cowboy. 😄 |
I've added another commit, upgrading cowboy to 2.6. To regards to the test you're referring to... The test used to use the returned req object that exposed access to the socket. The new req object currently looks like:
None of which allow you to upgrade the current connection manually. |
Ping. |
Hey, sorry been swamped. I'll set a reminder to take another look at this next week. |
As per #63 this is the minimal code change for dependency upgrade, including support for elixir 1.6 by downgrading exdoc.