Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated dependencies, formatting, dialyzer, credo #63

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

InoMurko
Copy link

@InoMurko InoMurko commented Nov 8, 2018

Removed all associations to the request object since it's been deprecated in latest cowboy.

@ayrat555
Copy link

@Azolo Can you take a look, please?

@Azolo
Copy link
Owner

Azolo commented Nov 15, 2018

Sorry, am out of town. There's a lot of changes here, so I will as soon as I get back.

@@ -0,0 +1,2 @@
erlang 21.1
elixir 1.7.3-otp-21

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this project supports Elixir 1.3. Is this a generated file included by mistake?

@mmartinson
Copy link

@InoMurko a bit of feedback to help make PRs easier to review (I general, I am not a maintainer of this project). It's best, if you intend to run the code formatter as part of your patch, to do it in a separate commit from something like updating dependencies. It ends up making a large and noisy diff for review, and also looks confusing when looking at git history. Additionally, it creates a larger surface area for unnecessary merge conflicts.

I'm not sure if this would be an issue getting this particular patch in, but taking the code formatting out and making a different PR for it could help move it through more quickly.

@InoMurko
Copy link
Author

@mmartinson you're perfectly right. I first made the changes for myself and after that decided to push it upstream - hence the merger with formatting. If it's an issue we can't get pass I can rework that.

There's a dependency reason why I decided to deprecate old Elixir versions, not exactly sure which one but I can figure it out next week!

@mmartinson
Copy link

It looks like exdoc 0.19 requires 1.7, but 0.18 will support back to 1.3.
plug_cowboy 2.0 requires 1.5
dialyxir 1.0-rcx requires 1.6
Not sure if I missed any

I find it tricky to determine how many previous language versions are worth supporting for a given library in general, but for a newer one like this that likely doesn't have a couple years being adopted to production, I think supporting 1 trailing version is reasonable.

With that, I would suggest changing exdoc to 0.18, and requiring >= Elixir 1.6 in mix.exs

@InoMurko
Copy link
Author

That makes sense and it should be an easy change. Thanks for your input!

@Azolo
Copy link
Owner

Azolo commented Nov 16, 2018

I'm not sure if this would be an issue getting this particular patch in, but taking the code formatting out and making a different PR for it could help move it through more quickly.

This.

If they were smaller changes or changes I could glance over and merge then I would.
But right now going through it all is a time commitment I don't have.

Thanks @mmartinson for the help.

@InoMurko
Copy link
Author

Ok. I’ll change this over the weekend or next week!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants