-
Notifications
You must be signed in to change notification settings - Fork 797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Jetpack icon to gutenberg features powered by Jetpack #9579
Conversation
Jumping in for Michael while he's out. I think the concept here is great for reinforcing the brand, I just think we need to tighten up the logomark a bit here. It's almost indistinguishable at this size and doesn't resemble the real logomark much at all. Let me see if I can make some adjustments in a mockup, quickly! I'll get back to you @gravityrail @oskosk |
Thanks @jeffgolenski. You should know that the inserter style has changed since this patch was created, since we merged WordPress/gutenberg#6636 in particular. It's worth building Gutenberg from Master to see the latest that will be coming out with 3.0. |
Also the ability to set a bg color on the block icon card is coming soon. |
@jeffgolenski Do you have an update on your mock? If not, @gravityrail I'd say let's stand down for now until the support for a custom background color comes through, as @mtias mentions. What are your thoughts, considering the discussing here too p6TEKc-23j-p2 ? |
FWIW, I think there's added value in labeling Jetpack features as |
@keoshi I do not. I never got a chance to get to it last week. Happy to stand down and defer to you for this moving forward. I like the idea about adding "Jetpack" for discoverability. |
Moving this into next release, since it looks like not ready yet. @gravityrail are you still want this to be merged? |
Just pinging @MichaelArestad since he's been thinking a bit about this |
This change helps show the user which Gutenberg blocks are powered by Jetpack by putting a little Jetpack icon in the corner of the block's editor icon.
Changes proposed in this Pull Request:
Testing instructions:
Screenshot