Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Jetpack icon to gutenberg features powered by Jetpack #9579

Closed
wants to merge 3 commits into from

Conversation

gravityrail
Copy link
Contributor

This change helps show the user which Gutenberg blocks are powered by Jetpack by putting a little Jetpack icon in the corner of the block's editor icon.

Changes proposed in this Pull Request:

  • Add Jetpack icon in corner of blocks powered by Jetpack.

Testing instructions:

  • Install Gutenberg
  • Edit a post
  • Open the "insert block" dialog
  • Search for "VR"
  • Should have a little green icon indicating it's a Jetpack feature :)

Screenshot

jetpack-gutenberg-icon

@gravityrail gravityrail requested a review from a team as a code owner May 18, 2018 16:14
@gravityrail gravityrail added the [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack label May 18, 2018
@gravityrail gravityrail self-assigned this May 18, 2018
@gravityrail gravityrail added this to the 6.2 milestone May 18, 2018
@gravityrail
Copy link
Contributor Author

@oskosk oskosk added the [Status] Needs Design Review Design has been added. Needs a review! label May 31, 2018
@jeffgolenski
Copy link
Member

Jumping in for Michael while he's out. I think the concept here is great for reinforcing the brand, I just think we need to tighten up the logomark a bit here. It's almost indistinguishable at this size and doesn't resemble the real logomark much at all.

Let me see if I can make some adjustments in a mockup, quickly! I'll get back to you @gravityrail @oskosk

@gravityrail
Copy link
Contributor Author

Thanks @jeffgolenski. You should know that the inserter style has changed since this patch was created, since we merged WordPress/gutenberg#6636 in particular. It's worth building Gutenberg from Master to see the latest that will be coming out with 3.0.

@gravityrail
Copy link
Contributor Author

cc @youknowriad @mtias

@mtias
Copy link
Member

mtias commented May 31, 2018

Also the ability to set a bg color on the block icon card is coming soon.

@keoshi
Copy link
Contributor

keoshi commented Jun 4, 2018

@jeffgolenski Do you have an update on your mock? If not, @gravityrail I'd say let's stand down for now until the support for a custom background color comes through, as @mtias mentions. What are your thoughts, considering the discussing here too p6TEKc-23j-p2 ?

@keoshi
Copy link
Contributor

keoshi commented Jun 4, 2018

FWIW, I think there's added value in labeling Jetpack features as Jetpack: Feature Name. It helps with discoverability, makes them searchable by Jetpack (as opposed to Beautiful Math alone), and creates a nice grouping for all of them.

@jeffgolenski
Copy link
Member

@keoshi I do not. I never got a chance to get to it last week. Happy to stand down and defer to you for this moving forward. I like the idea about adding "Jetpack" for discoverability.

@matticbot matticbot added [Status] Needs Design Review Design has been added. Needs a review! [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack Touches WP.com Files labels Jun 5, 2018
@oskosk oskosk modified the milestones: 6.2, 6.3 Jun 6, 2018
@brbrr brbrr added the [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it label Jun 20, 2018
@brbrr brbrr modified the milestones: 6.3, 6.4 Jul 2, 2018
@brbrr
Copy link
Contributor

brbrr commented Jul 31, 2018

Moving this into next release, since it looks like not ready yet.

@gravityrail are you still want this to be merged?

@brbrr brbrr modified the milestones: 6.4, 6.5 Jul 31, 2018
@jeffgolenski
Copy link
Member

Just pinging @MichaelArestad since he's been thinking a bit about this

@oskosk oskosk removed this from the 6.5 milestone Aug 30, 2018
@jeherve jeherve deleted the add/jetpack-icon-gutenberg branch September 25, 2018 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Status] Needs Design Review Design has been added. Needs a review! [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants