Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HAL_QURT: revived QURT HAL #27091

Merged
merged 9 commits into from
Jul 12, 2024
Merged

HAL_QURT: revived QURT HAL #27091

merged 9 commits into from
Jul 12, 2024

Conversation

tridge
Copy link
Contributor

@tridge tridge commented May 18, 2024

This is a revival of the old QURT HAL for the new ModalAI boards, testing on a starling dev copter

this builds on #27504

Issues:

  • mavlink bridge doesn't support ArduPilot specific mavlink XML
  • fix so name libslpi_hello_world.so to some other name
  • UDP fwding in ap_host sometimes stops
  • sl_client_config_uart needs to be fixed to not have side effects for invalid baudrate
  • doesn't yet build ARM frontend app
  • only getting ESC telem from 3 ESCs (check ESC fw version and config?)
  • scripting not working
  • storage takes a long time to sync
  • not getting current from ESC telem
  • need to implement ESC power API
  • should have a default param file
  • need to fix reboot
  • getting corrupt MAVLink pkts from ap_host
  • need to test VIO, rangefinder, flow etc
  • reduce number of build warnings with clang
  • setup CI for qurt.ardupilot.org
  • why the 2048 offset in current?

Testing:

  • use ./waf configure --board QURT
  • build: ./waf copter

libraries/AP_Baro/AP_Baro.h Outdated Show resolved Hide resolved
libraries/AP_Baro/AP_Baro_config.h Outdated Show resolved Hide resolved
libraries/AP_BattMonitor/AP_BattMonitor_INA2xx.cpp Outdated Show resolved Hide resolved
libraries/AP_HAL_QURT/Scheduler.cpp Show resolved Hide resolved
libraries/AP_HAL_QURT/Storage.cpp Show resolved Hide resolved
libraries/AP_HAL_QURT/ap_host/src/getifaddrs.cpp Outdated Show resolved Hide resolved
libraries/AP_HAL_QURT/ap_host/src/main.cpp Show resolved Hide resolved
libraries/AP_HAL_QURT/ap_host/src/main.cpp Outdated Show resolved Hide resolved
@@ -0,0 +1,80 @@
# parameters for the autonomy dev kit
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MP's parameter loader apparently can't see files below the "Frame_params" directory so perhaps we should move this up and add a prefix. E.g. "ModalAI_AutonomyDevKit.parm"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as discussed on the call, once merged I will do a MissionPlanner PR to support this directory, like I did for quadplanes

@rmackay9 rmackay9 added the WikiNeeded needs wiki update label Jul 8, 2024
@rmackay9
Copy link
Contributor

rmackay9 commented Jul 8, 2024

We should add pages to the developer wiki to clarify how to setup the build environment

Copy link
Collaborator

@davidbuzz davidbuzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this PR seems to rely elmost entirely on POSIX pthread/s , and I wonder if it shouldn't be called AP_HAL_PTHREADS or AP_HAL_POSIX, or have an intermediate layer for the pthreads and/or posix related stuff... especially since other hal/s like Linux and ESP32 both have posix and pthreads support.

eg esp32 pthreads support here: https://docs.espressif.com/projects/esp-idf/en/stable/esp32/api-reference/system/pthread.html

That's more of a suggestion for the future tho, not a stopper for this PR, which clearly works well-enough to merge.

@tridge tridge mentioned this pull request Jul 10, 2024
@tridge tridge force-pushed the pr-hal-qurt-v2 branch 2 times, most recently from 5a2fce5 to e982bd0 Compare July 11, 2024 01:22
Copy link
Contributor

@peterbarker peterbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from the very minor things raised.

libraries/AP_HAL/board/qurt.h Outdated Show resolved Hide resolved
libraries/AP_HAL_QURT/DeviceBus.cpp Outdated Show resolved Hide resolved
libraries/AP_HAL_QURT/Scheduler.cpp Outdated Show resolved Hide resolved
libraries/AP_HAL_QURT/UARTDriver.cpp Outdated Show resolved Hide resolved
libraries/AP_HAL_QURT/UARTDriver.cpp Outdated Show resolved Hide resolved
libraries/AP_HAL_QURT/UARTDriver.cpp Show resolved Hide resolved
libraries/AP_HAL_QURT/Util.cpp Outdated Show resolved Hide resolved
libraries/AP_HAL_QURT/Util.h Outdated Show resolved Hide resolved
fixes replay build with posix compat changes
based around new SDK for ModalAI Voxl2 vehicles
@tridge tridge merged commit 4273711 into ArduPilot:master Jul 12, 2024
93 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants