fix: issue with paging account history #144

antazoey · 2024-07-05T16:50:26Z

the pager for account history was broken.
you would get to the end and it would try the next page anyway, causing a 500 error.

also, adds missing docs for using account query history.
Also fixes an issue where result: None would crash the handlers, and you get that sometimes.

also fixes the testnet name and tests for scroll

Passes all linting checks (pre-commit and CI jobs)
New test cases have been added and are passing
Documentation has been updated
PR title follows Conventional Commit standard (will be automatically included in the changelog)

antazoey added 4 commits July 5, 2024 10:36

fix: issue with paging

03c67e9

test: fix scroll tests

f40d7f1

test: test new fixes

68e020f

test: correct test case

920e1a2

antazoey mentioned this pull request Jul 5, 2024

fix: issue with paging account history #143

Closed

4 tasks

antazoey requested a review from fubuloubu July 5, 2024 16:51

antazoey enabled auto-merge (squash) July 5, 2024 16:51

fubuloubu previously approved these changes Jul 5, 2024

View reviewed changes

fix: testnet for scroll was wrong

d44bfb2

antazoey dismissed fubuloubu’s stale review via d44bfb2 July 5, 2024 17:04

antazoey disabled auto-merge July 5, 2024 17:12

antazoey merged commit a6d03aa into main Jul 5, 2024
25 checks passed

antazoey deleted the docs/query branch July 5, 2024 17:12

This pull request was closed.

Provide feedback