fix: issue with paging account history #143
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antazoey
commented
Jul 5, 2024
| ```python | ||
| from ape import chain | ||
|
|
||
| history = chain.history["vitalik.eth"] |
There was a problem hiding this comment.
requires this fix: ApeWorX/ape#2170
antazoey
commented
Jul 5, 2024
| @@ -456,10 +459,11 @@ def _get_page_of_normal_transactions( | |||
| } | |||
| result = self._get(params=params) | |||
|
|
|||
| if not isinstance(result.value, list): | |||
| raise UnhandledResultError(result, result.value) | |||
| value = result.value or [] | |||
There was a problem hiding this comment.
another fix: sometimes this is None and that is still 200 / ok.
for example, give it the ZERO_ADDRESS and you get this.
antazoey
commented
Jul 5, 2024
| @@ -278,6 +278,10 @@ def get_url_f(testnet: bool = False, tld: str = "io"): | |||
| "gnosis": { | |||
| "mainnet": url("gnosisscan"), | |||
| }, | |||
| "scroll": { | |||
There was a problem hiding this comment.
this was a miss from #137
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
the pager for account history was broken.
you would get to the end and it would try the next page anyway, causing a 500 error.
How I did it
if no more items, break out of the loop
How to verify it
Checklist