Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(top-level): remove depd patch-package workaround #1314

Merged
merged 1 commit into from
Jul 20, 2020

Conversation

warner
Copy link
Member

@warner warner commented Jul 20, 2020

SES (in 'errorTaming: unsafe' mode) now tolerates the way that depd modifies
Error, and install-ses uses that mode. So now we can stop patching depd.

This reverts commit a8f1308.

closes #1229

@warner warner requested a review from michaelfig July 20, 2020 04:15
@warner warner self-assigned this Jul 20, 2020
Copy link
Member

@michaelfig michaelfig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Negative code day FTW!

SES (in 'errorTaming: unsafe' mode) now tolerates the way that depd modifies
Error, and `install-ses` uses that mode. So now we can stop patching depd.

This reverts commit a8f1308.

closes #1229
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove depd patch-package once Error taming is fixed
2 participants