Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove depd patch-package once Error taming is fixed #1229

Closed
warner opened this issue Jun 28, 2020 · 0 comments · Fixed by #1314
Closed

remove depd patch-package once Error taming is fixed #1229

warner opened this issue Jun 28, 2020 · 0 comments · Fixed by #1314
Assignees
@warner
Labels
tooling repo-wide infrastructure

Comments

@warner
Copy link
Member

warner commented Jun 28, 2020

During the new-SES work, I had to add a patch-package call to our top-level package.json. This used @kumavis 's trick from endojs/endo#251 .

Once that issue is fixed and we've updated to a version of SES that allows start-compartment code to modify Error (specifically .prepareStackTrace and .stackTraceLimit) in a way that's compatible with depd, we should remove the patch and the use of patch-package.
@warner warner added the tooling repo-wide infrastructure label Jun 28, 2020
@warner warner self-assigned this Jun 28, 2020
warner added a commit that referenced this issue Jul 20, 2020
@warner
fix(top-level): remove depd patch-package workaround
4d7987c 
SES (in 'errorTaming: unsafe' mode) now tolerates the way that depd modifies
Error, and `install-ses` uses that mode. So now we can stop patching depd.

This reverts commit a8f1308.

closes #1229
@warner warner mentioned this issue Jul 20, 2020
Merged
@warner warner closed this as completed in 354a3ae Jul 20, 2020
@snyk-bot snyk-bot mentioned this issue Sep 16, 2021
Open
@snyk-bot snyk-bot mentioned this issue Nov 5, 2022
Open
@Kashuhackerone Kashuhackerone mentioned this issue Dec 25, 2022
Open
@Kashuhackerone Kashuhackerone mentioned this issue Jun 21, 2023
Open
@Kashuhackerone Kashuhackerone mentioned this issue Dec 19, 2023
Open
@Kashuhackerone Kashuhackerone mentioned this issue May 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@warner warner

Labels
tooling repo-wide infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(top-level): remove depd patch-package workaround Agoric/agoric-sdk
1 participant
@warner