Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8 Tasks done to add h1 tag in pages #325

Merged
merged 11 commits into from
Jun 24, 2023

Conversation

jgyfutub
Copy link
Contributor

Describe your changes

I have removed headerTitle props from .tsx code of these pages p and manually put

tag for headings. Below is the screenshots for work done.Please inform in case of any problem occurs.

Screenshots - If Any (Optional)


2023-06-14
About - Accessible Web Dev and 2 more pages - Personal - Microsoft​ Edge 14-06-2023 17_57_35
About - Accessible Web Dev and 2 more pages - Personal - Microsoft​ Edge 14-06-2023 17_58_33
About - Accessible Web Dev and 2 more pages - Personal - Microsoft​ Edge 14-06-2023 17_58_44

Link to issue

Closes #315

Checklist before requesting a review

  • [yes] I have performed a self-review of my code.
  • [yes] Followed the repository's Contributing Guidelines.
  • [yes] I ran the app and tested it locally to verify that it works as expected.
  • [no] I have checked my code with an automatic accessibility tool such as Axe Dev Tools or Wave
    and it shows no errors.

Additional Information (Optional)

Any additional information that you want to give us.

@jgyfutub
Copy link
Contributor Author

The above pages are about page,404 page, index page and [content] page respectively from up to down.

Copy link
Member

@EmmaDawsonDev EmmaDawsonDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert the changes to things that aren't related to the h1 issue.

@EmmaDawsonDev
Copy link
Member

Do you need some help with this @jgyfutub ?

@jgyfutub
Copy link
Contributor Author

jgyfutub commented Jun 23, 2023

@EmmaDawsonDev I had removed all commits that were not related to h1 please review the changes. But differences in yarn.lock file are showing too much.Please help me solve this problem

@EmmaDawsonDev
Copy link
Member

Looks like you need to revert this commit 68baba645d476aa55c52c66896c31ffae7890388 in order to remove the changes to the yarn.lock file and the package.json file. Neither of these files should be included in this PR.

@jgyfutub
Copy link
Contributor Author

ok I will try thanks for helping.

removing yarn.lock and package.json commit
This reverts commit 68baba6.
@jgyfutub
Copy link
Contributor Author

jgyfutub commented Jun 23, 2023

I have removed the yarn.lock and package.json commit by using git revert , please review the changes.

Copy link
Member

@EmmaDawsonDev EmmaDawsonDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you for persevering with this 😃

@EmmaDawsonDev EmmaDawsonDev merged commit 45bf454 into AccessibleForAll:main Jun 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move h1 from layout into each page
2 participants