-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8 Tasks done to add h1 tag in pages #325
Conversation
The above pages are about page,404 page, index page and [content] page respectively from up to down. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please revert the changes to things that aren't related to the h1 issue.
Do you need some help with this @jgyfutub ? |
@EmmaDawsonDev I had removed all commits that were not related to h1 please review the changes. But differences in yarn.lock file are showing too much.Please help me solve this problem |
Looks like you need to revert this commit |
ok I will try thanks for helping. |
removing yarn.lock and package.json commit This reverts commit 68baba6.
I have removed the yarn.lock and package.json commit by using git revert , please review the changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thank you for persevering with this 😃
Describe your changes
I have removed headerTitle props from .tsx code of these pages p and manually put
tag for headings. Below is the screenshots for work done.Please inform in case of any problem occurs.
Screenshots - If Any (Optional)
Link to issue
Closes #315
Checklist before requesting a review
and it shows no errors.
Additional Information (Optional)
Any additional information that you want to give us.