Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move h1 from layout into each page #315

Closed
8 tasks
EmmaDawsonDev opened this issue Jun 10, 2023 · 2 comments · Fixed by #325
Closed
8 tasks

Move h1 from layout into each page #315

EmmaDawsonDev opened this issue Jun 10, 2023 · 2 comments · Fixed by #325
Assignees

Comments

@EmmaDawsonDev
Copy link
Member

  • Remove the h1 from the Layout component
  • Remove the headerTitle prop from the interface and props in the Layout component
  • Remove the h1 styles from the Layout styles file
  • Add a h1 to the index page before the first section. Remove the headerTitle prop from Layout and add the text directly into the h1.
  • Add a h1 to the [content] page before as the first element inside the fragment. Remove the headerTitle prop from Layout and add the text directly into the h1
  • Add a h1 to the about page before the first section. Remove the headerTitle prop from Layout and add the text directly into the h1.
  • Add a h1 to the 404 page before the first div. Remove the headerTitle prop from Layout and add the text directly into the h1.
  • Add a font-size for the h1 into the global styles file. Set it to 2.5 rem.
@jgyfutub
Copy link
Contributor

can I work on this one?

@EmmaDawsonDev
Copy link
Member Author

Sure 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants