Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All 8 tasks done and .PageLastUpdated class shifted #320

Closed
wants to merge 6 commits into from

Conversation

jgyfutub
Copy link
Contributor

Describe your changes

I have done all the 8 tasks given in issue and shifted .PageLastUpdated class from global.css to PageUpdated.module.css. I have also removed tailwind files due to which my changes were unable to run. I have performed self-review of code and ran the app and was working as expected. If any error occurs, please inform me so that I can work on it.

Screenshots - If Any (Optional)

Link to issue

Closes #316
Closes #315

Checklist before requesting a review

  • [yes ] I have performed a self-review of my code.
  • [yes ] Followed the repository's Contributing Guidelines.
  • [yes ] I ran the app and tested it locally to verify that it works as expected.
  • [no ] I have checked my code with an automatic accessibility tool such as Axe Dev Tools or Wave
    and it shows no errors.

Additional Information (Optional)

Any additional information that you want to give us.

Copy link
Member

@EmmaDawsonDev EmmaDawsonDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Each individual issue should have a separate pull request. That way, if something goes wrong it is much easier to track down where problems arose and work out a way to fix them. In order to make three separate pull requests you will need to make your changes in separate branches.

You can use git checkout -b NewBranchName to create a new branch where you change NewBranchName for something related to the fix you are making. For example git checkout -b fix/move-header. Then make the changes related only to the header and make a pull request for that. Do the same for the other issues you've been assigned and then make pull requests for those too.

Let me know if you need any more help.

@jgyfutub
Copy link
Contributor Author

jgyfutub commented Jun 13, 2023

okk thanks for informing and helping me as I am new to open source contribution and trying to enhance my collaboration skills👍👍

@jgyfutub jgyfutub closed this Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move pageLastUpdated CSS to correct module Move h1 from layout into each page
2 participants