🐛 Remove the OPENEXR_INSTALL_EXAMPLES CMake option #1666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cary-ilm
requested changes
Mar 10, 2024
website/install.rst
Outdated
| @@ -460,7 +460,7 @@ Component Options | |||
| Install the binary programs (exrheader, exrinfo, | |||
| exrmakepreview, etc). Default is ``ON``. | |||
|
|
|||
| * ``OPENEXR_INSTALL_EXAMPLES`` | |||
| * ``OPENEXR_BUILD_EXAMPLES`` | |||
|
|
|||
| Build and install the example code. Default is ``ON``. | |||
There was a problem hiding this comment.
Should remove any reference to install here:
Suggested change
| Build and install the example code. Default is ``ON``. | |
| Build the example code. Default is ``ON``. |
There was a problem hiding this comment.
Thank you! I've submitted an updated commit.
The OPENEXR_INSTALL_EXAMPLES option is misleading and doesn't have any effect. It might be safely removed in favor of the OPENEXR_BUILD_EXAMPLES option. Co-authored-by: Cary Phillips <cary@ilm.com> Signed-off-by: Aliaksei Urbanski <aliaksei.urbanski@gmail.com>
Jamim
force-pushed
the
fix/build-examples-option
branch
from
4811de4
to
bd47a0a
Compare
pleprince
pushed a commit
to pleprince/openexr_clusty
that referenced
this pull request
Mar 12, 2024
…undation#1666) The OPENEXR_INSTALL_EXAMPLES option is misleading and doesn't have any effect. It might be safely removed in favor of the OPENEXR_BUILD_EXAMPLES option. Signed-off-by: Aliaksei Urbanski <aliaksei.urbanski@gmail.com> Co-authored-by: Cary Phillips <cary@ilm.com> Signed-off-by: Philippe Leprince <github.pleprince@gmail.com>
cary-ilm
added a commit
that referenced
this pull request
Mar 23, 2024
The OPENEXR_INSTALL_EXAMPLES option is misleading and doesn't have any effect. It might be safely removed in favor of the OPENEXR_BUILD_EXAMPLES option. Signed-off-by: Aliaksei Urbanski <aliaksei.urbanski@gmail.com> Co-authored-by: Cary Phillips <cary@ilm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @cary-ilm,
The
OPENEXR_INSTALL_EXAMPLESoption is misleading and doesn't have any effect.It might be safely removed in favor of the
OPENEXR_BUILD_EXAMPLESoption.Best regards!