Skip to content

Commit

Permalink
🐛 Remove the OPENEXR_INSTALL_EXAMPLES CMake option
Browse files Browse the repository at this point in the history
The OPENEXR_INSTALL_EXAMPLES option is misleading and doesn't have any effect.
It might be safely removed in favor of the OPENEXR_BUILD_EXAMPLES option.

Co-authored-by: Cary Phillips <cary@ilm.com>
Signed-off-by: Aliaksei Urbanski <aliaksei.urbanski@gmail.com>
  • Loading branch information
Jamim and cary-ilm committed Mar 10, 2024
1 parent 502b246 commit bd47a0a
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 5 deletions.
3 changes: 1 addition & 2 deletions cmake/OpenEXRSetup.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,7 @@ option(OPENEXR_BUILD_LIBS "Enables building of main libraries" ON)
option(OPENEXR_BUILD_TOOLS "Enables building of utility programs" ON)
option(OPENEXR_INSTALL_TOOLS "Install OpenEXR tools" ON)

option(OPENEXR_BUILD_EXAMPLES "Build OpenEXR examples" ON)
option(OPENEXR_INSTALL_EXAMPLES "Install OpenEXR examples" ON)
option(OPENEXR_BUILD_EXAMPLES "Build and install OpenEXR examples" ON)

option(OPENEXR_BUILD_PYTHON "Build python bindings" OFF)

Expand Down
1 change: 0 additions & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@ metadata.version.provider-path = "./src/wrappers/python"
OPENEXR_INSTALL = 'OFF'
OPENEXR_BUILD_PYTHON = 'ON'
OPENEXR_BUILD_EXAMPLES = 'OFF'
OPENEXR_INSTALL_EXAMPLES = 'OFF'
OPENEXR_BUILD_TOOLS = 'OFF'
OPENEXR_INSTALL_TOOLS = 'OFF'
OPENEXR_INSTALL_PKG_CONFIG = 'OFF'
Expand Down
4 changes: 2 additions & 2 deletions website/install.rst
Original file line number Diff line number Diff line change
Expand Up @@ -460,9 +460,9 @@ Component Options
Install the binary programs (exrheader, exrinfo,
exrmakepreview, etc). Default is ``ON``.

* ``OPENEXR_INSTALL_EXAMPLES``
* ``OPENEXR_BUILD_EXAMPLES``

Build and install the example code. Default is ``ON``.
Build the example code. Default is ``ON``.

Additional CMake Options
~~~~~~~~~~~~~~~~~~~~~~~~
Expand Down

0 comments on commit bd47a0a

Please sign in to comment.