Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply recent run layer call optimization to batched execution #1669

Conversation

chellmuth
Copy link
Collaborator

Description

Copy-paste the run layer call checks from #1665 into the batched execution mode.

Checklist:

  • I have read the contribution guidelines.
  • I have previously submitted a Contributor License Agreement.
  • I have updated the documentation, if applicable.
  • I have ensured that the change is tested somewhere in the testsuite (adding new test cases if necessary).
  • My code follows the prevailing code style of this project.

Signed-off-by: Chris Hellmuth <chellmuth@gmail.com>
@chellmuth chellmuth force-pushed the optimize-run-layer-calls--batched branch from 2ef8e0d to e4f7344 Compare April 12, 2023 00:08
Copy link
Contributor

@AlexMWells AlexMWells left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for updating the batched side as well

@lgritz lgritz merged commit 7ebfbc4 into AcademySoftwareFoundation:main Apr 12, 2023
lgritz pushed a commit that referenced this pull request Apr 14, 2023
Copy-paste the run layer call checks from #1665 into the batched execution mode.

Signed-off-by: Chris Hellmuth <chellmuth@gmail.com>
chellmuth pushed a commit to chellmuth/OpenShadingLanguage that referenced this pull request Sep 6, 2024
* Enable userdata derivatives for interpolated params on GPU (AcademySoftwareFoundation#1657)
* Don't insert redundant run layer calls inside a basic block (AcademySoftwareFoundation#1665)
* Apply recent run layer call optimization to batched execution (AcademySoftwareFoundation#1669)
* fix for ReParameterization corner case (AcademySoftwareFoundation#1670)

See merge request spi/dev/3rd-party/osl-feedstock!45
chellmuth pushed a commit to chellmuth/OpenShadingLanguage that referenced this pull request Sep 6, 2024
  * Don't insert redundant run layer calls inside a basic block (AcademySoftwareFoundation#1665)
  * Apply recent run layer call optimization to batched execution (AcademySoftwareFoundation#1669)
  * Do-over: Make recent run-layer optimizations optional, and fix
    init ops-related false positive (AcademySoftwareFoundation#1672)
  * fix for ReParameterization corner case (AcademySoftwareFoundation#1670)
  * RendererServices API for letting get_texture_handle consider colorspace (AcademySoftwareFoundation#1641)
  * Set up ray types for testrender (AcademySoftwareFoundation#1648)
  * testrender: Don't use the cached background map on the first bounce (AcademySoftwareFoundation#1649)
  * Switch lockgeom to interpolated and interactive (AcademySoftwareFoundation#1662)
  * Add type information for needed attributes. (AcademySoftwareFoundation#1650)

Note that this bump to 1.13.3.x is only for Arnold at this point, and
not yet for the platforms, so to make CI go faster I have rigged
.spdev.yaml to only build the sparnold versions at this time.

Also updated ABI dump files.

See merge request spi/dev/3rd-party/osl-feedstock!47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants