-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
testrender: Don't use the cached background map on the first bounce #1649
testrender: Don't use the cached background map on the first bounce #1649
Conversation
…camera ray) Signed-off-by: Chris Kulla <ckulla@gmail.com>
ce748c5
to
8a50d78
Compare
…mportance sampling is enabled by default Signed-off-by: Chris Kulla <ckulla@gmail.com>
As discussed on slack, I also bumped the default resolution in the event that someone forgets to set it in the xml so that we get better sampling out of the box. |
I think that this changes a couple of the test outputs slightly so they need new ref images. If you don't have time to do that tonight, I believe I can just retrieve the updated images from the CI and push another commit on top of yours that fixes it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks @fpsunflower!
…cademySoftwareFoundation#1649) * testrender: Don't use the cached background map on the first bounce (camera ray) * testrender: Change the default resolution of the background so that importance sampling is enabled by default Signed-off-by: Chris Kulla <ckulla@gmail.com>
* Don't insert redundant run layer calls inside a basic block (AcademySoftwareFoundation#1665) * Apply recent run layer call optimization to batched execution (AcademySoftwareFoundation#1669) * Do-over: Make recent run-layer optimizations optional, and fix init ops-related false positive (AcademySoftwareFoundation#1672) * fix for ReParameterization corner case (AcademySoftwareFoundation#1670) * RendererServices API for letting get_texture_handle consider colorspace (AcademySoftwareFoundation#1641) * Set up ray types for testrender (AcademySoftwareFoundation#1648) * testrender: Don't use the cached background map on the first bounce (AcademySoftwareFoundation#1649) * Switch lockgeom to interpolated and interactive (AcademySoftwareFoundation#1662) * Add type information for needed attributes. (AcademySoftwareFoundation#1650) Note that this bump to 1.13.3.x is only for Arnold at this point, and not yet for the platforms, so to make CI go faster I have rigged .spdev.yaml to only build the sparnold versions at this time. Also updated ABI dump files. See merge request spi/dev/3rd-party/osl-feedstock!47
This lets users customize the behavior of the background for camera rays (requested by the MaterialX team). Without this, you always get the cached copy which is only valid for one raytype (and has limited resolution) or you don't get any importance sampling of the environment.