Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Fixing descriptions of inversed NamedTransforms #117

Merged
merged 3 commits into from
Oct 18, 2023
Merged

[BugFix] Fixing descriptions of inversed NamedTransforms #117

merged 3 commits into from
Oct 18, 2023

Commits on Oct 12, 2023

  1. Fixing descriptions of inversed NamedTransforms 

    Generate the transform description based on the transform's direction.

Resolves: AcademySoftwareFoundation#111

Signed-off-by: Allison Moon <147774452+ajymoonILM@users.noreply.github.com>
    @ajymoonILM
    ajymoonILM committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    dae24f2 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2023

  1. Update addressing KelSolaar's review: 

    - changing function args from `inverse_direction` (bool) to `direction` (str)

Signed-off-by: Allison Moon <147774452+ajymoonILM@users.noreply.github.com>
    @ajymoonILM
    ajymoonILM committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    1f65687 View commit details
    Browse the repository at this point in the history

  2. Update addressing KelSolaar's review: 

    - Case-insensitive check of `direction` args

Signed-off-by: Allison Moon <147774452+ajymoonILM@users.noreply.github.com>
    @ajymoonILM
    ajymoonILM committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    2a311ee View commit details
    Browse the repository at this point in the history