[BugFix] Fixing descriptions of inversed NamedTransforms #117
Conversation
Generate the transform description based on the transform's direction. Resolves: AcademySoftwareFoundation#111 Signed-off-by: Allison Moon <147774452+ajymoonILM@users.noreply.github.com>
|
Thanks for this fix @ajymoonILM ! I had to manually start the CI unit tests, since you are a new contributor. It looks like they will succeed. Please let us know if you have suggestions for how to improve the installation instructions (at a minimum it seems we need to clarify that one should start a Poetry shell before using the invoke command). |
|
Thanks a lot @ajymoonILM! I haven't checked the artifacts but the code seems to do what we want! The only thing I have to say is that I would prefer to rename |
- changing function args from `inverse_direction` (bool) to `direction` (str) Signed-off-by: Allison Moon <147774452+ajymoonILM@users.noreply.github.com>
|
Thanks @KelSolaar ! |
| @@ -204,7 +205,7 @@ def clf_transform_to_description( | |||
| DescriptionStyle.SHORT_UNION, | |||
| ): | |||
| if clf_transform.description is not None: | |||
| if inverse_direction: | |||
| if direction == "Forward": | |||
There was a problem hiding this comment.
maybe if direction.lower() == "forward": so that it becomes case insensitive?
LGTM otherwise and thank you!
There was a problem hiding this comment.
Updated with the case insensitive check.
Let me know of anything else that needs to be addressed!
There was a problem hiding this comment.
We are good! Thanks a lot @ajymoonILM!
- Case-insensitive check of `direction` args Signed-off-by: Allison Moon <147774452+ajymoonILM@users.noreply.github.com>
Generate the transform description based on the transform's direction.
Resolves: #111