select2 widget not initialized on plone5 #48
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jone
reviewed
Dec 12, 2019
…h stops propogation)
djowett-ftw
force-pushed
the
dj_select2_widget_not_initialized_on_plone5
branch
from
8bae78b
to
22c7863
Compare
|
Thanks for looking
Yes - for this issue
It is in the JS above - inserted previously to prevent conflict between Plone's v3.5 select2 and v4.0.2 in this product
I think you're thinking of the fix in #46?
Done - good call :-) |
|
This fix is included in #47 which has just been merged, so closing this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #42
BUT #46 is not resolved, so this shouldn't be released without a fix for that ticket