Fix product to work on Plone5 in production #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
:-( Oh - seems to still not work with bundles in production |
added 7 commits
December 10, 2019 17:09
Also Fix on click event for edit form tabs
- Rework JS for Plone5
- Move Plone's Select2 aside while running JS for this product
- Add select2 v4.0 into our bundle without inlining it in our source
Note: we ensure correct ordering of the select2 libraries by using 'depends' on the bundle rather than 'require' in JS
- Rebuild with plone-compile-resources (added to test-plone-5.1 buildout)
…ds; set compile false
…ect passed back from require call instead of the installed jquery plugin
djowett-ftw
force-pushed
the
dj_fix_for_production_in_plone5
branch
from
13b9aef
to
2340347
Compare
|
This now uses yarn and works in a production setup (contrary to the notes above) |
|
@maethu quick question - while working on this I notice that the SCSS file is ahead of the CSS file, but there seems to be no generation of the latter from the former. How should this worK? |
|
@djowett-ftw I kinda don't understand the question. We usually use scss and not css anymore. With ftw.theming wit use mostly scss. |
maethu
approved these changes
Dec 12, 2019
This was referenced Dec 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #46
Also fixes #42 on click event for edit form tabs
This doesn't yet use the @buchi method (with yarn) for the JS compilation. That's on the way.