Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slack: Mark edited messages with a pencil icon #683

Closed
wants to merge 1 commit into from

Conversation

nylen
Copy link
Contributor

@nylen nylen commented Jan 9, 2019

When sending messages to Slack, edited messages are updated silently without the (edited) text that appears when a regular user edits a message.

We can't fix that, but we can make a cosmetic improvement to make it clearer that the message was edited:

In (Discord) Out (Slack)
2019-01-08t23 08 21-05 00 2019-01-08t23 08 06-05 00

@patcon
Copy link
Contributor

patcon commented Jan 9, 2019

Related: #614

@42wim
Copy link
Owner

42wim commented Jan 13, 2019

The pencil icon idea is pretty cool.
There already is an EditSuffix option which allows you to set a "(edited)" message of your choice. (you could set it there)

#Message to be appended to every edited message
#OPTIONAL (default empty)
EditSuffix=" (edited)"

I think it's better to add a EditPrefix option if you/other people really need it prefixed.

@nylen
Copy link
Contributor Author

nylen commented Jan 18, 2019

Same as in #682...

There already is an EditSuffix option which allows you to set a "(edited)" message of your choice. (you could set it there)

I didn't see this, maybe it's in a different part of the code. I think this will work fine...

I think it's better to add a EditPrefix option if you/other people really need it prefixed.

No strong feelings about this. Probably not worth adding another setting, especially if the suffix already works.

I'll test the suffix and either fix it in this PR, or close this PR.

@nylen
Copy link
Contributor Author

nylen commented Mar 11, 2019

Closing, I haven't had time to revisit this, and as discussed above it may already be covered by existing functionality.

@nylen nylen closed this Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants