Discord: Mark edited webhook messages with a pencil icon

[nylen]

When using a webhook to send messages to Discord with avatar spoofing, edited messages are posted twice. This is because Discord doesn't allow editing a message sent by a webhook.

We can't fix that, but we can make a cosmetic improvement to make it clearer that the second copy of the message is actually an edit of the previous message:

In (Slack)	Out (Discord)

bwmarrin/discordgo#622 will allow further improvements, for example:

• Remove the hack of using -webhook- as a placeholder for the ID of the original message on Discord
• Add a 📝 reaction to the original message to make it clearer that it has been edited

[ghost]

Found some fixes!

P.S. share your ideas, feedbacks or issues with us at https://github.com/fixmie/feedback (this message will be removed after the beta stage).

[patcon]

Related (as the edit format might not suit all bridge platforms or use-case): #614

[42wim]

Good idea!
Seems like I haven't implemented the EditSuffix for the discord webhook.
The rest of my comment is the same as in #683
We could make a EditPrefix instead of hardcoding this.

[nylen]

Seems like I haven't implemented the EditSuffix for the discord webhook.

Cool, I'll take a look at this. I didn't know there was an EditSuffix setting.

We could make a EditPrefix instead of hardcoding this.

I'd also be fine with a suffix here actually. Maybe we should start with that, and see if we still want a prefix in another PR?

[42wim]

@nylen would be great if you would make a PR to have EditSuffix fixed for webhooks too!
If the suffix works and is enough, we don't need the prefix one.

[patcon]

To clarify, at risk of beating a dead horse: the prefix-suffix decision is a moot point if we instead lean on templating for message types <3

EditSuffix can be deprecated in favour of smthng like EditFormat, with:

• default: EditFormat="{{content}}"
• suffix via EditFormat="{{content}} (edited)"
• prefix via EditFormat="[:pencil:] {{content}}"
• etc etc

[42wim]

@nylen did you test it with the EditSuffix ? if so can we close this PR? and the other about slack ?

[nylen]

Closing. I haven't had time to revisit this but it is probably covered by existing functionality.