Skip to content
This repository has been archived by the owner on Dec 12, 2023. It is now read-only.

Map validation rules to current FedRAMP review processes #45

Merged
merged 148 commits into from
Jan 15, 2021

Conversation

ohsh6o
Copy link

@ohsh6o ohsh6o commented Jan 1, 2021

Implements #40.

brian-ruf and others added 6 commits October 11, 2020 20:12
Establishes `response-point` properties in the FedRAMP High, Moderate, and Low Rev 4 profiles to clearly identify the statement level at which FedRAMP requires CSPs to respond to controls definitions within the SSP for each control (part a, part b.1, part b.2, etc.). These response-points align with the exiting Rev 4 High, Moderate, and Low FedRAMP SSP Word Templates.

This change also identifies the control objective level at which assessors must respond to control objectives within the Test Case Workbook (TCW). This replaces the use of FedRAMP conformity tags for this purpose, and brings the control-objective approach into better alignment with the control definition approach above.
These response-points align with the exiting Rev 4 High, Moderate, and Low TCW Excel Templates.
Per discussion over pending work in #32, we want
to further enhance the XML content defined in the FedRAMP Registry as
saved in the Excel XSLX file to include defined identifiers for roles
particular to FedRAMP not the current milestone release of upstream
OSCAL.
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@ohsh6o
Copy link
Author

ohsh6o commented Jan 2, 2021

@brianrufgsa, I know we had discussed this earlier this week, but will mapping tasklists like this for Section B and Section C into comments about individuals rule checks (asserts and reports) in the Schematron source code (so ssp.sch and I think it will end up in the resolved ssp.xsl) and also include those identifiers into the (B.1.0 or C.1a) into the SVRL output from running the checks.

I wanted you to have take a look next week and let me know, and if this works for now, I will proceed on integrating this more fully into the README, source code, and outputs as offered. Have a good weeekend!

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@ohsh6o ohsh6o marked this pull request as ready for review January 6, 2021 23:07
@github-actions

This comment has been minimized.

aj-stein-gsa and others added 10 commits January 14, 2021 18:36
For #40, we will move a high-level mapping of rules to the README and
technical information will go to the CONTRIBUTING.md file.
Per conversation with @brianrufgsa earlier this week, as we continue to
follow the dichotomy of informational validation data in sch:report and
encoding warnings and errors in sch:assert checks, it is not completely
transparent that the reports are information that is not an error, but
a useful reporting item. Brian suggested he would like this to be marked
with something like positive, so we shall start doing that and document
it.
* adding a spec that is broken

in the spirit of:
 - make it break
 - make it work
 - make it pretty

Formatting Report...
passed: 21 / pending: 0 / failed: 4 / total: 25

* surpress some of the xpspec output

* fix the test

* make scenario for party be invalid party-uuid instead of role-id
* fix id's to be more specific
* make scenario for rol be invalid role-id instead of party-uuid

* add rule for parties, roles and responsible-party association

* restructure test location under master SSP scenario per feedback
@ohsh6o ohsh6o force-pushed the issue-40-map-validations-to-fedramp-workflow-checklist branch from 35b135f to b09b78d Compare January 14, 2021 23:36
@github-actions
Copy link

Unit Test Results

  1 files  ±0    2 suites  ±0   0s ⏱️ ±0s
  0 tests ±0    0 ✔️ ±0  0 💤 ±0  0 ✖️ ±0 
43 runs  ±0  43 ✔️ ±0  0 💤 ±0  0 ✖️ ±0 

results for commit b09b78d ± comparison against base commit d518ad1

@github-actions
Copy link

Unit Test Results

  1 files  ±0    2 suites  ±0   0s ⏱️ ±0s
  0 tests ±0    0 ✔️ ±0  0 💤 ±0  0 ✖️ ±0 
43 runs  ±0  43 ✔️ ±0  0 💤 ±0  0 ✖️ ±0 

results for commit 9cd5aed ± comparison against base commit d518ad1

@github-actions
Copy link

Unit Test Results

  1 files  ±0    2 suites  ±0   0s ⏱️ ±0s
  0 tests ±0    0 ✔️ ±0  0 💤 ±0  0 ✖️ ±0 
43 runs  ±0  43 ✔️ ±0  0 💤 ±0  0 ✖️ ±0 

results for commit e4e30a9 ± comparison against base commit d518ad1

@github-actions
Copy link

Unit Test Results

  1 files  ±0    2 suites  ±0   0s ⏱️ ±0s
  0 tests ±0    0 ✔️ ±0  0 💤 ±0  0 ✖️ ±0 
43 runs  ±0  43 ✔️ ±0  0 💤 ±0  0 ✖️ ±0 

results for commit a73bad3 ± comparison against base commit d518ad1

@github-actions
Copy link

Unit Test Results

  1 files  ±0    2 suites  ±0   0s ⏱️ ±0s
  0 tests ±0    0 ✔️ ±0  0 💤 ±0  0 ✖️ ±0 
43 runs  ±0  43 ✔️ ±0  0 💤 ±0  0 ✖️ ±0 

results for commit 495de09 ± comparison against base commit d518ad1

Copy link

@mike-stern mike-stern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the approach, having an attribute organizational-id dedicated to the crosswalk to the authorizing bodies process.

Given the scope of the validations will most likely be contained in the context of a repository, it may not be necessary but I wonder aloud if we should consider an organizational-body in this case organizational-body = FedRAMP to contextualize/scope the rule we are implementing.


## What is this?

This is the FedRAMP Validation Suite, a framework to take [FedRAMP documentation](https://www.fedramp.gov/templates/) that is properly formatted with [NIST OSCAL schemas](https://pages.nist.gov/OSCAL/) and check the content for correctness. [FedRAMP's adoption of OSCAL](https://www.youtube.com/watch?v=WCPkt56vZ-s) allows you to use this framework to perform logical validations, i.e. business rule checks, on documentation content. Currently, FedRAMP staff manually review the content provided by a cloud service provider for all steps of the [different](https://github.com/GSA/fedramp-gov/blob/master/assets/img/agency-auth.png) [authorization](https://github.com/GSA/fedramp-gov/blob/master/assets/img/ato-auth.png) processes. This framework and the associated business rules will automate as many of these checks as possible. Shared expectations are the goal: system owners, third-party assessors, or any interested party can use them as well.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good distinction to make. I can see this readme incorporate a link to (or a marked-up version) of this. The reason to potentially 'mark it up' would be to indicate where in the process flow this instrumentation lives (think "you are here"). Additionally, when the adjudication extension is adopted, updating the readme to switch any vernacular that is specific to the model will further strengthen the concept.

resources/xml/fedramp_values.xml Show resolved Hide resolved
@github-actions
Copy link

Unit Test Results

  1 files  ±0    2 suites  ±0   0s ⏱️ ±0s
  0 tests ±0    0 ✔️ ±0  0 💤 ±0  0 ✖️ ±0 
43 runs  ±0  43 ✔️ ±0  0 💤 ±0  0 ✖️ ±0 

results for commit ea14b13 ± comparison against base commit d518ad1

@ohsh6o ohsh6o merged commit 6524f06 into master Jan 15, 2021
@ohsh6o ohsh6o deleted the issue-40-map-validations-to-fedramp-workflow-checklist branch January 15, 2021 21:01
@github-actions

This comment has been minimized.

@github-actions
Copy link

github-actions bot commented May 3, 2021

Unit Test Results

0 files  -  1  0 suites  -2   0s ⏱️ ±0s
0 tests ±  0  0 ✔️ ±  0  0 💤 ±0  0 ✖️ ±0 
0 runs  -43  0 ✔️ -43  0 💤 ±0  0 ✖️ ±0 

results for commit 6524f06 ± comparison against base commit d518ad1

2 similar comments
@github-actions
Copy link

github-actions bot commented May 3, 2021

Unit Test Results

0 files  -  1  0 suites  -2   0s ⏱️ ±0s
0 tests ±  0  0 ✔️ ±  0  0 💤 ±0  0 ✖️ ±0 
0 runs  -43  0 ✔️ -43  0 💤 ±0  0 ✖️ ±0 

results for commit 6524f06 ± comparison against base commit d518ad1

@github-actions
Copy link

github-actions bot commented May 4, 2021

Unit Test Results

0 files  -  1  0 suites  -2   0s ⏱️ ±0s
0 tests ±  0  0 ✔️ ±  0  0 💤 ±0  0 ✖️ ±0 
0 runs  -43  0 ✔️ -43  0 💤 ±0  0 ✖️ ±0 

results for commit 6524f06 ± comparison against base commit d518ad1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
6 participants