Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed Location Management Missing Attributes #266

Merged
merged 6 commits into from
Jul 3, 2024

Conversation

willguibr
Copy link
Member

@willguibr willguibr commented Jul 2, 2024

Provide a general summary of your changes in the title above. You should
remove this overview, any sections and any section descriptions you
don't need below before submitting. There isn't a strict requirement to
use this template if you can structure your description and still cover
these points.

Description

Describe your changes in detail through motivation and context. Why is
this change required? What problem does it solve? If it fixes an open
issue, link to the issue using GitHub's closing issues keywords1.

Has your change been tested?

Explain how the change has been tested and what you ran to confirm your
change affects other parts of the code. Automated tests are generally
expected and changes without tests should explain why they aren't
required.

Screenshots (if appropriate):

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented and stable APIs.

@willguibr willguibr temporarily deployed to ZCON_ZSCALER_BETA July 2, 2024 22:41 — with GitHub Actions Inactive
@willguibr willguibr temporarily deployed to ZPA_PROD_TENANT01 July 2, 2024 22:41 — with GitHub Actions Inactive
@willguibr willguibr self-assigned this Jul 2, 2024
@willguibr willguibr added bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request labels Jul 2, 2024
@willguibr willguibr added the zia-new-attributes ZIA API Added New Parameters label Jul 2, 2024
@willguibr willguibr added the In development Under active development label Jul 2, 2024
@willguibr willguibr temporarily deployed to ZCON_ZSCALER_THREE July 2, 2024 22:43 — with GitHub Actions Inactive
Copy link

codecov bot commented Jul 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.82%. Comparing base (adfc0b1) to head (ef44d8b).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #266      +/-   ##
==========================================
+ Coverage   57.79%   58.82%   +1.02%     
==========================================
  Files         151      162      +11     
  Lines        5938     6190     +252     
==========================================
+ Hits         3432     3641     +209     
- Misses       2036     2050      +14     
- Partials      470      499      +29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request In development Under active development zia-new-attributes ZIA API Added New Parameters
Projects
Status: 🚀 Shipped
Development

Successfully merging this pull request may close these issues.

1 participant