Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ZPA API Client Restructure #258

Merged
merged 16 commits into from
Jun 14, 2024
Merged

Conversation

willguibr
Copy link
Member

@willguibr willguibr commented Jun 11, 2024

Provide a general summary of your changes in the title above. You should
remove this overview, any sections and any section descriptions you
don't need below before submitting. There isn't a strict requirement to
use this template if you can structure your description and still cover
these points.

Description

Describe your changes in detail through motivation and context. Why is
this change required? What problem does it solve? If it fixes an open
issue, link to the issue using GitHub's closing issues keywords1.

Has your change been tested?

Explain how the change has been tested and what you ran to confirm your
change affects other parts of the code. Automated tests are generally
expected and changes without tests should explain why they aren't
required.

Screenshots (if appropriate):

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented and stable APIs.

Copy link

codecov bot commented Jun 11, 2024

Codecov Report

Attention: Patch coverage is 77.07692% with 149 lines in your changes missing coverage. Please review.

Project coverage is 57.98%. Comparing base (ec4afdd) to head (931ff97).

Files Patch % Lines
zdx/services/troubleshooting/analysis/analysis.go 0.00% 19 Missing ⚠️
...onnectorcontroller/zpa_app_connector_controller.go 0.00% 16 Missing ⚠️
...ediatecacertificates/intermediatecacertificates.go 21.05% 15 Missing ⚠️
zdx/services/alerts/alerts.go 50.00% 10 Missing and 3 partials ⚠️
.../reports/applications/application_score_metrics.go 66.66% 7 Missing and 1 partial ⚠️
...dx/services/troubleshooting/deeptrace/deeptrace.go 69.23% 4 Missing and 4 partials ⚠️
...ervices/adminuserrolemgmt/adminroles/adminroles.go 22.22% 7 Missing ⚠️
zdx/services/reports/devices/device_web_probes.go 66.66% 5 Missing ⚠️
...n/services/locationmanagement/location/location.go 33.33% 4 Missing ⚠️
...con/services/provisioning/api_keys/provisioning.go 0.00% 4 Missing ⚠️
... and 26 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #258      +/-   ##
==========================================
+ Coverage   53.17%   57.98%   +4.81%     
==========================================
  Files         279      172     -107     
  Lines        6782     6410     -372     
==========================================
+ Hits         3606     3717     +111     
+ Misses       2691     2172     -519     
- Partials      485      521      +36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
Status: 🚀 Shipped
Development

Successfully merging this pull request may close these issues.

ZDX applications GetAllApps endpoint bug
1 participant