Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added microtenant support to new application segment endpoints #256

Merged
merged 5 commits into from
Jun 7, 2024

Conversation

willguibr
Copy link
Member

@willguibr willguibr commented Jun 7, 2024

Provide a general summary of your changes in the title above. You should
remove this overview, any sections and any section descriptions you
don't need below before submitting. There isn't a strict requirement to
use this template if you can structure your description and still cover
these points.

Description

Describe your changes in detail through motivation and context. Why is
this change required? What problem does it solve? If it fixes an open
issue, link to the issue using GitHub's closing issues keywords1.

Has your change been tested?

Explain how the change has been tested and what you ran to confirm your
change affects other parts of the code. Automated tests are generally
expected and changes without tests should explain why they aren't
required.

Screenshots (if appropriate):

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented and stable APIs.

@willguibr willguibr temporarily deployed to ZCON_ZSCALER_BETA June 7, 2024 05:23 — with GitHub Actions Inactive
@willguibr willguibr self-assigned this Jun 7, 2024
@willguibr willguibr added enhancement New feature or request new-acceptance-tests New acceptance tests ZPA New API Resources ZPA New API Resources In development Under active development labels Jun 7, 2024
Copy link

codecov bot commented Jun 7, 2024

Codecov Report

Attention: Patch coverage is 63.80952% with 38 lines in your changes missing coverage. Please review.

Project coverage is 53.05%. Comparing base (488342c) to head (9467afa).

Files Patch % Lines
zpa/services/applicationsegment_move/service.go 20.00% 8 Missing ⚠️
zpa/services/applicationsegment_share/service.go 20.00% 8 Missing ⚠️
...applicationsegment_move/applicationsegment_move.go 50.00% 3 Missing and 3 partials ⚠️
...vices/appconnectorschedule/appconnectorschedule.go 79.16% 3 Missing and 2 partials ⚠️
...ervices/serviceedgeschedule/serviceedgeschedule.go 79.16% 3 Missing and 2 partials ⚠️
...plicationsegment_share/applicationsegment_share.go 66.66% 2 Missing and 2 partials ⚠️
zpa/services/authdomain/authdomain.go 71.42% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #256      +/-   ##
==========================================
+ Coverage   52.70%   53.05%   +0.35%     
==========================================
  Files         269      279      +10     
  Lines        6721     6782      +61     
==========================================
+ Hits         3542     3598      +56     
+ Misses       2708     2695      -13     
- Partials      471      489      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@willguibr willguibr temporarily deployed to ZCON_ZSCALER_BETA June 7, 2024 07:54 — with GitHub Actions Inactive
@willguibr willguibr temporarily deployed to ZPA_PROD_TENANT01 June 7, 2024 07:54 — with GitHub Actions Inactive
@willguibr willguibr temporarily deployed to ZCON_ZSCALER_THREE June 7, 2024 07:55 — with GitHub Actions Inactive
@willguibr willguibr merged commit 0c7cb58 into master Jun 7, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request In development Under active development new-acceptance-tests New acceptance tests ZPA New API Resources ZPA New API Resources
Projects
Status: 🚀 Shipped
Development

Successfully merging this pull request may close these issues.

1 participant