-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #206 from zscaler/zia-#206-dlp-engine-web-rule-att…
…ribute (fix): Added missing dlp engine and web dlp rule attributes
- Loading branch information
Showing
6 changed files
with
232 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,151 @@ | ||
| package dlp_engines | ||
|
|
||
| import ( | ||
| "strings" | ||
| "testing" | ||
|
|
||
| "github.com/zscaler/zscaler-sdk-go/v2/tests" | ||
| "golang.org/x/text/cases" | ||
| "golang.org/x/text/language" | ||
| ) | ||
|
|
||
| func TestDLPEngineLite_data(t *testing.T) { | ||
| client, err := tests.NewZiaClient() | ||
| if err != nil { | ||
| t.Errorf("Error creating client: %v", err) | ||
| return | ||
| } | ||
|
|
||
| service := New(client) | ||
|
|
||
| engines, err := service.GetAll() | ||
| if err != nil { | ||
| t.Errorf("Error getting predefined engine name: %v", err) | ||
| return | ||
| } | ||
| if len(engines) == 0 { | ||
| t.Errorf("No predefined engine name found") | ||
| return | ||
| } | ||
| name := engines[0].PredefinedEngineName | ||
| t.Log("Getting predefined engine name by name:" + name) | ||
| engine, err := service.GetByPredefinedEngine(name) | ||
| if err != nil { | ||
| t.Errorf("Error getting predefined engine by name: %v", err) | ||
| return | ||
| } | ||
| if engine.PredefinedEngineName != name { | ||
| t.Errorf("predefined engine name does not match: expected %s, got %s", name, engine.PredefinedEngineName) | ||
| return | ||
| } | ||
| // Negative Test: Try to retrieve an predefined engine name with a non-existent name | ||
| nonExistentName := "ThisPredefinedEngineDoesNotExist" | ||
| _, err = service.GetByPredefinedEngine(nonExistentName) | ||
| if err == nil { | ||
| t.Errorf("Expected error when getting by non-existent name, got nil") | ||
| return | ||
| } | ||
| } | ||
|
|
||
| func TestGetById(t *testing.T) { | ||
| client, err := tests.NewZiaClient() | ||
| if err != nil { | ||
| t.Fatalf("Error creating client: %v", err) | ||
| } | ||
|
|
||
| service := New(client) | ||
|
|
||
| // Get all engines to find a valid ID | ||
| engines, err := service.GetAll() | ||
| if err != nil { | ||
| t.Fatalf("Error getting all dlp predefined engine: %v", err) | ||
| } | ||
| if len(engines) == 0 { | ||
| t.Fatalf("No dlp predefined engines found for testing") | ||
| } | ||
|
|
||
| // Choose the first engines's ID for testing | ||
| testID := engines[0].ID | ||
|
|
||
| // Retrieve the engine by ID | ||
| engine, err := service.Get(testID) | ||
| if err != nil { | ||
| t.Errorf("Error retrieving dlp predefined engine with ID %d: %v", testID, err) | ||
| return | ||
| } | ||
|
|
||
| // Verify the retrieved engine | ||
| if engine == nil { | ||
| t.Errorf("No engine returned for ID %d", testID) | ||
| return | ||
| } | ||
|
|
||
| if engine.ID != testID { | ||
| t.Errorf("Retrieved engine ID mismatch: expected %d, got %d", testID, engine.ID) | ||
| } | ||
| } | ||
|
|
||
| func TestResponseFormatValidation(t *testing.T) { | ||
| client, err := tests.NewZiaClient() | ||
| if err != nil { | ||
| t.Errorf("Error creating client: %v", err) | ||
| return | ||
| } | ||
|
|
||
| service := New(client) | ||
|
|
||
| engines, err := service.GetAll() | ||
| if err != nil { | ||
| t.Errorf("Error getting predefined engine: %v", err) | ||
| return | ||
| } | ||
| if len(engines) == 0 { | ||
| t.Errorf("No predefined engine found") | ||
| return | ||
| } | ||
|
|
||
| // Validate predefined engine | ||
| for _, engine := range engines { | ||
| // Checking if essential fields are not empty | ||
| if engine.ID == 0 { | ||
| t.Errorf("predefined engine ID is empty") | ||
| } | ||
| if !engine.CustomDlpEngine && engine.PredefinedEngineName == "" { | ||
| t.Errorf("predefined engine Name is empty for predefined engine with ID: %d", engine.ID) | ||
| } | ||
| } | ||
| } | ||
|
|
||
| func TestCaseSensitivityOfGetByName(t *testing.T) { | ||
| client, err := tests.NewZiaClient() | ||
| if err != nil { | ||
| t.Errorf("Error creating client: %v", err) | ||
| return | ||
| } | ||
|
|
||
| service := New(client) | ||
|
|
||
| // Assuming a group with the name "EXTERNAL" exists | ||
| knownName := "EXTERNAL" | ||
|
|
||
| // Case variations to test | ||
| variations := []string{ | ||
| strings.ToUpper(knownName), | ||
| strings.ToLower(knownName), | ||
| cases.Title(language.English).String(knownName), | ||
| } | ||
|
|
||
| for _, variation := range variations { | ||
| t.Logf("Attempting to retrieve group with name variation: %s", variation) | ||
| engine, err := service.GetByPredefinedEngine(variation) | ||
| if err != nil { | ||
| t.Errorf("Error getting predefined engine with name variation '%s': %v", variation, err) | ||
| continue | ||
| } | ||
|
|
||
| // Check if the group's actual name matches the known name | ||
| if engine.PredefinedEngineName != knownName { | ||
| t.Errorf("Expected group name to be '%s' for variation '%s', but got '%s'", knownName, variation, engine.PredefinedEngineName) | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters